Closed
Conversation
dom96
requested changes
Feb 11, 2026
Contributor
dom96
left a comment
There was a problem hiding this comment.
Yeah, we don't want the package-lock.json so that we can avoid having to bump the packages all the time. I think the package.json should supply a version requirement which installs whatever the latest wrangler is (or whatever the latest 4.x version is).
Contributor
Author
|
@dom96 I see. Then probably this PR is not needed. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump wrangler versions in the repo to the latest to better support windows.
I also added the
package-lock.jsonfile in the each directory, I am not sure if it is our intention not to include that file though (If that is the case, maybe we should add it to gitignore?)