Remove the autogate for using StateMachine in CompressionStream (#6072)

jasnell · web-flow · commit 3274cc980a0a · 2026-02-13T09:21:38.000-08:00
Autogate is deployed
diff --git a/src/workerd/api/streams/compression.c++ b/src/workerd/api/streams/compression.c++
@@ -466,63 +466,10 @@ class CompressionStreamBase: public kj::Refcounted,
   RingBuffer<PendingRead, 8> pendingReads;
 };
 
-// Uncompressed data goes in. Compressed data comes out.
-// TODO(cleanup): Once the autogate is removed, delete this class and merge CompressionStreamBase
-// and CompressionStreamImplV2 back into a single class.
 template <Context::Mode mode>
 class CompressionStreamImpl final: public CompressionStreamBase<mode> {
  public:
   explicit CompressionStreamImpl(kj::String format,
-      Context::ContextFlags flags,
-      kj::Arc<const jsg::ExternalMemoryTarget>&& externalMemoryTarget)
-      : CompressionStreamBase<mode>(kj::mv(format), flags, kj::mv(externalMemoryTarget)) {}
-
- protected:
-  void requireActive(kj::StringPtr errorMessage) override {
-    KJ_SWITCH_ONEOF(state) {
-      KJ_CASE_ONEOF(ended, Ended) {
-        JSG_FAIL_REQUIRE(Error, errorMessage);
-      }
-      KJ_CASE_ONEOF(exception, kj::Exception) {
-        kj::throwFatalException(kj::cp(exception));
-      }
-      KJ_CASE_ONEOF(open, Open) {
-        return;
-      }
-    }
-    KJ_UNREACHABLE;
-  }
-
-  void transitionToEnded() override {
-    state = Ended();
-  }
-
-  void transitionToErrored(kj::Exception&& reason) override {
-    state = kj::mv(reason);
-  }
-
-  void throwIfException() override {
-    KJ_IF_SOME(exception, state.template tryGet<kj::Exception>()) {
-      kj::throwFatalException(kj::cp(exception));
-    }
-  }
-
-  virtual bool isInTerminalState() override {
-    // Ended or Exception are both terminal states.
-    return state.template is<Ended>() || state.template is<kj::Exception>();
-  }
-
- private:
-  struct Ended {};
-  struct Open {};
-
-  kj::OneOf<Open, Ended, kj::Exception> state = Open();
-};
-
-template <Context::Mode mode>
-class CompressionStreamImplV2 final: public CompressionStreamBase<mode> {
- public:
-  explicit CompressionStreamImplV2(kj::String format,
       Context::ContextFlags flags,
       kj::Arc<const jsg::ExternalMemoryTarget>&& externalMemoryTarget)
       : CompressionStreamBase<mode>(kj::mv(format), flags, kj::mv(externalMemoryTarget)),
@@ -634,11 +581,6 @@ kj::Rc<CompressionStreamBase<Context::Mode::COMPRESS>> createCompressionStreamIm
     kj::String format,
     Context::ContextFlags flags,
     kj::Arc<const jsg::ExternalMemoryTarget>&& externalMemoryTarget) {
-  // TODO(cleanup): Once the autogate is removed, we can delete CompressionStreamImpl
-  if (util::Autogate::isEnabled(util::AutogateKey::COMPRESSION_STREAM_USE_STATE_MACHINE)) {
-    return kj::rc<CompressionStreamImplV2<Context::Mode::COMPRESS>>(
-        kj::mv(format), flags, kj::mv(externalMemoryTarget));
-  }
   return kj::rc<CompressionStreamImpl<Context::Mode::COMPRESS>>(
       kj::mv(format), flags, kj::mv(externalMemoryTarget));
 }
@@ -647,11 +589,6 @@ kj::Rc<CompressionStreamBase<Context::Mode::DECOMPRESS>> createDecompressionStre
     kj::String format,
     Context::ContextFlags flags,
     kj::Arc<const jsg::ExternalMemoryTarget>&& externalMemoryTarget) {
-  // TODO(cleanup): Once the autogate is removed, we can delete CompressionStreamImpl
-  if (util::Autogate::isEnabled(util::AutogateKey::COMPRESSION_STREAM_USE_STATE_MACHINE)) {
-    return kj::rc<CompressionStreamImplV2<Context::Mode::DECOMPRESS>>(
-        kj::mv(format), flags, kj::mv(externalMemoryTarget));
-  }
   return kj::rc<CompressionStreamImpl<Context::Mode::DECOMPRESS>>(
       kj::mv(format), flags, kj::mv(externalMemoryTarget));
 }
diff --git a/src/workerd/util/autogate.c++ b/src/workerd/util/autogate.c++
@@ -29,8 +29,6 @@ kj::StringPtr KJ_STRINGIFY(AutogateKey key) {
       return "fetch-request-memory-adjustment"_kj;
     case AutogateKey::RUST_BACKED_NODE_DNS:
       return "rust-backed-node-dns"_kj;
-    case AutogateKey::COMPRESSION_STREAM_USE_STATE_MACHINE:
-      return "compression-stream-use-state-machine"_kj;
     case AutogateKey::IDENTITY_TRANSFORM_STREAM_USE_STATE_MACHINE:
       return "identity-transform-stream-use-state-machine"_kj;
     case AutogateKey::RPC_USE_EXTERNAL_PUSHER:
diff --git a/src/workerd/util/autogate.h b/src/workerd/util/autogate.h
@@ -24,8 +24,6 @@ enum class AutogateKey {
   FETCH_REQUEST_MEMORY_ADJUSTMENT,
   // Enable Rust-backed Node.js DNS implementation
   RUST_BACKED_NODE_DNS,
-  // Switch the CompressionStream to use the new state machine-based impl
-  COMPRESSION_STREAM_USE_STATE_MACHINE,
   // Switch the IdentityTransformStream to use the new state machine-based impl
   IDENTITY_TRANSFORM_STREAM_USE_STATE_MACHINE,
   // Use ExternalPusher instead of StreamSink to handle streams in RPC.
