add node:net module#3315

Merged

anonrig merged 7 commits intomainfrom

yagiz/add-node-net

Jan 14, 2025

Member

anonrig commented Jan 9, 2025 •

edited

Loading

Work in progress. Based on @jasnell's pull-request #2217 with couple of changes/additions

TODO

Write a bazel rule for testing TCP servers through Node.js
Add tests

anonrig requested a review from jasnell

January 9, 2025 22:12

anonrig requested review from a team as code owners

January 9, 2025 22:12

anonrig requested review from a team and dom96

January 9, 2025 22:12

anonrig force-pushed the yagiz/add-node-net branch from 4f60ae6 to 519fd7f Compare

January 9, 2025 22:14

Collaborator

jasnell commented Jan 9, 2025

Write a bazel rule for testing TCP servers through Node.js

So that it is absolutely clear... the original take on this PR relied on implementing TCP-ingress within workerd to allow workerd itself to act as a test server. We're backing off on that due to disagreements over the design of it and instead will be looking at having the bazel test start/stop a node.js-based test server to use for testing.

Collaborator

jasnell commented Jan 9, 2025

Add tests

The tests my original PR had are fairly comprehensive and should be relatively easy to port over with the new node.js-based test server approach.

bradzacher mentioned this pull request

Bug: Types from types/node are detected as error types typescript-eslint/typescript-eslint#10635

Closed

4 tasks

anonrig force-pushed the yagiz/add-node-net branch 3 times, most recently from 3345607 to 464a0a0 Compare

January 10, 2025 20:49

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-tcp-server.js Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-tcp-server.js Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-tcp-server.js Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-tcp-server.js Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-tcp-server.js Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/tests/net-nodejs-test.wd-test Outdated Show resolved Hide resolved

anonrig force-pushed the yagiz/add-node-net branch 7 times, most recently from cb624a0 to 9380b4c Compare

January 13, 2025 15:55

anonrig requested a review from jasnell

January 13, 2025 15:59

This comment was marked as resolved.

Sign in to view

anonrig force-pushed the yagiz/add-node-net branch 3 times, most recently from 6b20d21 to c87e32c Compare

January 14, 2025 17:13

anonrig force-pushed the yagiz/add-node-net branch from 46ede10 to cd566f5 Compare

January 14, 2025 19:35

jasnell approved these changes

View reviewed changes

jasnell added nodejs compat api socket labels

anonrig added 7 commits

January 14, 2025 15:59


          add node:net module

6f6f5d6


          fix eslint errors due to missing @types/node

8addbfe


          add tests that uses nodejs sidecar

67c8636


          remove unnecessary compat flag

9c5d679


          try to fix windows build

08a73f0


          disable node:net tests on windows

e7c83ca


          do not throw on setNoDelay

010175a

anonrig force-pushed the yagiz/add-node-net branch from cd566f5 to 010175a Compare

January 14, 2025 20:59

anonrig merged commit 12dff19 into main

15 checks passed

anonrig deleted the yagiz/add-node-net branch

January 14, 2025 21:33

thomasgauvin mentioned this pull request

feat: support Cloudflare Workers sidorares/node-mysql2#2289

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api nodejs compat socket