Skip to content

Handle ArrayBufferView type parameters in Python Response#5585

Merged
ryanking13 merged 1 commit intomainfrom
gyeongjae/python-workers-sdk-array-buffer-view
Nov 27, 2025
Merged

Handle ArrayBufferView type parameters in Python Response#5585
ryanking13 merged 1 commit intomainfrom
gyeongjae/python-workers-sdk-array-buffer-view

Conversation

@ryanking13
Copy link
Contributor

Workers' Response object accepts ArrayBufferView type objects as its body (doc), but in Python workers, it was rejected because of the allow list not handling those types correctly.

It was discovered in cloudflare/python-workers-examples#49 (comment).

@ryanking13 ryanking13 requested review from a team as code owners November 25, 2025 14:36
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but a few suggestions in the test code

@ryanking13
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ryanking13 ryanking13 force-pushed the gyeongjae/python-workers-sdk-array-buffer-view branch from aeb5de7 to 5afafa4 Compare November 26, 2025 05:00
github-actions bot added a commit that referenced this pull request Nov 26, 2025
@ryanking13 ryanking13 requested a review from hoodmane November 26, 2025 05:01
@ryanking13 ryanking13 force-pushed the gyeongjae/python-workers-sdk-array-buffer-view branch from 5afafa4 to 580e438 Compare November 27, 2025 05:20
@ryanking13 ryanking13 enabled auto-merge November 27, 2025 06:35
@ryanking13 ryanking13 disabled auto-merge November 27, 2025 07:00
@ryanking13 ryanking13 enabled auto-merge November 27, 2025 07:01
@ryanking13 ryanking13 merged commit acc564b into main Nov 27, 2025
32 of 33 checks passed
@ryanking13 ryanking13 deleted the gyeongjae/python-workers-sdk-array-buffer-view branch November 27, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants