Fix node:v8 cachedDataVersionTag to be a function#6005
Merged
petebacondarwin merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
8 tasks
anonrig
approved these changes
Feb 2, 2026
107ad2b to
e766d28
Compare
Merging this PR will improve performance by 13.17%
Performance Changes
Comparing 
Footnotes
|
Per the Node.js documentation, v8.cachedDataVersionTag() should be a function that returns an integer, not a constant. This change aligns the implementation with the Node.js API specification.
e766d28 to
4d719ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v8.cachedDataVersionTagto be a function that returns0instead of a constant0v8.cachedDataVersionTag()as a function returning an integerChanges
src/node/v8.ts: Changedexport const cachedDataVersionTag = 0toexport function cachedDataVersionTag(): number { return 0; }src/workerd/api/node/tests/v8-nodejs-test.js: Updated tests to verify it's a function and call it correctly