fix: ensure the same version is installed in host and pyodide venv#59
Merged
ryanking13 merged 13 commits intomainfrom Feb 9, 2026
Merged
fix: ensure the same version is installed in host and pyodide venv#59ryanking13 merged 13 commits intomainfrom
ryanking13 merged 13 commits intomainfrom
Conversation
e95c616 to
70d73be
Compare
Contributor
|
Is there a reason we can't install the packages in the Pyodide venv first? |
Contributor
|
Okay I see: > # We need to install to .venv-workers first, so that we can determine if the packages requested
> # by the user are valid.But surely we don't need to install them, we should be able to do |
Contributor
Author
|
The problem is that we don't know which versions are available in Pyodide index until we install packages from it. Maybe we can
but that makes the error handling slightly more complex, but we can try. |
dom96
reviewed
Feb 2, 2026
dom96
approved these changes
Feb 6, 2026
Contributor
dom96
left a comment
There was a problem hiding this comment.
I left a few suggestions for the tests, but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the same version is installed in the host venv and Pyodide venv.
The solution is a little bit ugly...
Once we have PEP 783 accepted and all the packages are hosted in PyPI, we should be able to get rid of these steps.
Before this change, the packages installed in the two venv were different, as follows: