Skip to content

Use the native implementation of node:tls#8514

Merged
petebacondarwin merged 4 commits intomainfrom
vicb/node-tls
Mar 18, 2025
Merged

Use the native implementation of node:tls#8514
petebacondarwin merged 4 commits intomainfrom
vicb/node-tls

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Mar 17, 2025 •
edited
Loading

connect and TLSSocket are implemented in workerd 20250310.�

See cloudflare/workerd#3594

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner March 17, 2025 08:22
@vicb vicb requested a review from a team March 17, 2025 08:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c98c631

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/unenv-preset Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 17, 2025
@vicb vicb requested a review from petebacondarwin March 17, 2025 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-wrangler-8514

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8514/npm-package-wrangler-8514

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-wrangler-8514 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-workers-bindings-extension-8514 -O ./cloudflare-workers-bindings-extension.0.0.0-v273ed715c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v273ed715c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-create-cloudflare-8514 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-kv-asset-handler-8514

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-miniflare-8514

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-pages-shared-8514

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-unenv-preset-8514

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-vite-plugin-8514

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-vitest-pool-workers-8514

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-workers-editor-shared-8514

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-workers-shared-8514

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13916825921/npm-package-cloudflare-workflows-shared-8514

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@4.1.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250317.0
workerd 1.20250317.0 1.20250317.0
workerd --version 1.20250317.0 2025-03-17

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb
Copy link
Contributor Author

vicb commented Mar 17, 2025

@petebacondarwin I added a second commit to update to the latest RC-15. Tested by updating wrangler to depend on the workspace version + rc15.

@vicb vicb added the e2e Run wrangler + vite-plugin e2e tests on a PR label Mar 17, 2025
@vicb
Copy link
Contributor Author

vicb commented Mar 18, 2025

rebase + fix lockfile

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 18, 2025
@petebacondarwin petebacondarwin merged commit 4ad78ea into main Mar 18, 2025
30 of 36 checks passed
@petebacondarwin petebacondarwin deleted the vicb/node-tls branch March 18, 2025 09:53
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 18, 2025
@workers-devprod workers-devprod mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicb @petebacondarwin @anonrig