Fix ADD row appearing on roster page for email sections (TEACHING-20) #70307
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where navigating from a word/picture section to an email section would incorrectly show an empty "add student" row. The issue occurred because loadSectionStudentData was called before the new section's loginType was set, causing it to use the previous section's loginType. Changes: - Set loginType from cached section data BEFORE calling loadSectionStudentData in asyncLoadSelectedSection - Added test to verify email login types don't create ADD row 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where navigating from a word/picture section to an email section would incorrectly show an empty "add student" row. The issue occurred because loadSectionStudentData was called before the new section's loginType was set, causing it to use the previous section's loginType.
Changes:
🤖 Generated with Claude Code
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: