refactor: Include java resources to final aar #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase version. Configure kotlin in tests
Contributor
Author
Collaborator
|
Hi. Thanks for your contribution . Can we save only META-INF/services files? |
Contributor
Author
|
Hi. Unfortunately, no. I have some dependencies where I must keep all resources. For instance, https://github.com/Locationtech/proj4j. OK, about the version. What should I do next? |
Collaborator
|
I think we can merge this PR without updating the version. After that @natario1 can release and publish the next version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase version. Configure kotlin in tests
Problem:
First of all, thanks for your plugin. I tried using the current version 0.3.4, and I found a bug. I have some logic related to Java SPI. I need to keep the META-INF/services/ directory in the jar file. But now, this directory is being excluded by the plugin. Or for this dependency I must keep all java resources.