fix(node compat): shake-128, shake-256 aliases for shake128 and shake256 hash algorithms#28451
Merged
littledivy merged 5 commits intodenoland:mainfrom Apr 10, 2025
Merged
Conversation
…256 digest algorithms
|
|
lilnasy
commented
Mar 10, 2025
Signed-off-by: Arsh <69170106+lilnasy@users.noreply.github.com>
marvinhagemeister
previously approved these changes
Mar 12, 2025
Contributor
There was a problem hiding this comment.
LGTM, thanks!
EDIT: Dismissed my review. Looks like somewhere else the aliases need to be wired up too. I'll leave it to @littledivy
Contributor
Author
|
The tests were failing because The other test failure looks like a flaky one: |
Contributor
Author
|
@littledivy This is ready to review. |
nayeemrmn
pushed a commit
that referenced
this pull request
Apr 11, 2025
) Fixes #28442 --------- Signed-off-by: Arsh <69170106+lilnasy@users.noreply.github.com> Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
dsherret
pushed a commit
that referenced
this pull request
Apr 11, 2025
) Fixes #28442 --------- Signed-off-by: Arsh <69170106+lilnasy@users.noreply.github.com> Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node:cryptodon't support the same inputs as Node.js #28442crypto_hash_test.tslocally against a debug build. The debug build passes, the current stable release fails.