fix(http): allow HEAD method in file-server#6752
Open
krugerLucas wants to merge 2 commits intodenoland:mainfrom
Open
fix(http): allow HEAD method in file-server#6752krugerLucas wants to merge 2 commits intodenoland:mainfrom
krugerLucas wants to merge 2 commits intodenoland:mainfrom
Conversation
This fixes an inconsistency where serveFile() supported HEAD requests but serveDir() returned 405 Method Not Allowed. Now both functions consistently support GET and HEAD methods. The fix changes line 658 in serveDir() to allow HEAD requests, which then properly delegate to serveFile() that already has correct HEAD implementation. Fixes denoland#6750
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 585 585
Lines 42367 42367
Branches 6683 6683
=======================================
Hits 39888 39888
Misses 2430 2430
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This doesn't change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistency where
serveFile()supported HEAD requests butserveDir()returned 405 Method Not Allowed.Problem
serveFile()correctly handles HEAD requests (returns headers without body)serveDir()rejects HEAD requests with 405 Method Not AllowedSolution
serveDir()to allow HEAD requests alongside GETserveFile()which already has correct implementationChanges
http/file_server.ts: Allow HEAD method in serveDir validationhttp/file_server_test.ts: Add tests for serveDirHeadRequest scenariosTest Plan
serveDirHeadRequestandserveDirHeadRequestForDirectoryWithIndexFixes #6750