fix(http): guard top-level Deno global access for browser compatibility#6987
Open
Asguho wants to merge 1 commit intodenoland:mainfrom
Open
fix(http): guard top-level Deno global access for browser compatibility#6987Asguho wants to merge 1 commit intodenoland:mainfrom
Asguho wants to merge 1 commit intodenoland:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6987 +/- ##
==========================================
- Coverage 94.20% 94.19% -0.01%
==========================================
Files 613 613
Lines 47710 47715 +5
Branches 8299 8299
==========================================
+ Hits 44945 44946 +1
- Misses 2697 2701 +4
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When importing
UserAgentor other utilities from@std/httpin a browser environment (e.g., via Vite), the application crashes. This occurs becausefile_server.tsperforms top-level execution of code accessing theDenoglobal namespace (specificallyDeno.permissionsandDeno.env) which does not exist in the browser.Solution:
This PR adds a
typeof Deno !== "undefined"check before attempting to access permission queries or environment variables. This ensures the module can be loaded in non-Deno environments without throwing aReferenceError.If there is anything else I can do to help this merge, please let me know.