Skip to content

feat: Add CONSTANT_CASE RegExp name lint check#6994

Open
timreichen wants to merge 3 commits intodenoland:mainfrom
timreichen:tools-regexp-constant-case-name-check
Open

feat: Add CONSTANT_CASE RegExp name lint check#6994
timreichen wants to merge 3 commits intodenoland:mainfrom
timreichen:tools-regexp-constant-case-name-check

Conversation

@timreichen
Copy link
Contributor

This PR adds a lint check that requires a CONSTANT_CASE RegExp declaration to either end in _REGEXP or be REGEXP. This ensures a uniform naming convention across all mods.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.20%. Comparing base (1cd85bf) to head (bc9f8f4).

Files with missing lines Patch % Lines
yaml/_loader_state.ts 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6994   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         613      613           
  Lines       47710    47715    +5     
  Branches     8299     8301    +2     
=======================================
+ Hits        44945    44951    +6     
  Misses       2697     2697           
+ Partials       68       67    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the uuid label Feb 8, 2026
@tomas-zijdemans
Copy link
Contributor

Nice! 👏
Would it make sense to rename:

  • RX_DEC_ENTITY_REGEXP to DEC_ENTITY_REGEXP
  • RX_HEX_ENTITY_REGEXP to HEX_ENTITY_REGEXP
  • and maybe also RX_REGEXP_ESCAPE to ESCAPE_REGEXP

@github-actions github-actions bot added the regexp label Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants