Skip to content

Commit 990b0da

Browse files
mstuartmstuart
committed
merge
2 parents 1c22c57 + fd831b4 commit 990b0da

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

‎README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ Subscribe buttons let you set up payment subscriptions.
5555
<script src="paypal-button.min.js?merchant=YOUR_MERCHANT_ID"
5656
data-button="subscribe"
5757
data-name="My product"
58-
data-a3="1.00"
59-
data-p3="1"
60-
data-t3="M"
58+
data-amount="1.00"
59+
data-recurrence="1"
60+
data-period="M"
6161
></script>
6262
```
6363

‎dist/paypal-button-minicart.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/paypal-button.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/paypal-button.js‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ PAYPAL.apps = PAYPAL.apps || {};
1717
prettyParams = {
1818
name: 'item_name',
1919
number: 'item_number',
20-
lang: 'lc'
20+
lang: 'lc',
21+
recurrence: 'p3',
22+
period: 't3'
2123
},
2224
buttonImgs = {
2325
buynow: '//www.paypalobjects.com/{locale}/i/btn/btn_buynow_{size}.gif',
@@ -83,6 +85,12 @@ PAYPAL.apps = PAYPAL.apps || {};
8385
// Subscribe buttons
8486
} else if (type === 'subscribe') {
8587
data.add('cmd', '_xclick-subscriptions');
88+
89+
// TODO: "amount" cannot be used in prettyParams since it's overloaded
90+
// Find a better way to do this
91+
if (data.items.amount && !data.items.a3) {
92+
data.add('a3', data.items.amount.value);
93+
}
8694
// Buy Now buttons
8795
} else {
8896
data.add('cmd', '_xclick');

‎test/index.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,10 @@ <h2>Subscribe (Small)</h2>
113113
<script src="../src/paypal-button.js?merchant=6XF3MPZBZV6HU"
114114
data-button="subscribe"
115115
data-name="Subscribe!"
116-
data-amount="1.00"
117116
data-size="small"
118-
data-a3="1.00"
119-
data-p3="1"
120-
data-t3="M"
117+
data-amount="1.00"
118+
data-recurrence="1"
119+
data-period="M"
121120
></script>
122121
</div>
123122

@@ -127,7 +126,8 @@ <h2>Subscribe (Large)</h2>
127126
data-button="subscribe"
128127
data-name="Subscribe!"
129128
data-amount="1.00"
130-
data-size="large"
129+
data-recurrence="1"
130+
data-period="M"
131131
></script>
132132
</div>
133133

0 commit comments

Comments
 (0)