Conversation
This adds a `"bun"` package.json `"exports"` condition which loads the browser build in Bun. Bun implements the [Web API `Worker` natively](https://bun.sh/docs/api/workers), and Bun's `node:worker_threads` implementation internally wraps the Web API `Worker`. `web-worker` currently loads the polyfills for Node in Bun (since we must recognize the `"node"` package.json `"exports"` condition for compatibility). This has actually been pretty helpful for catching bugs in our `node:worker_threads` implementation, but it'd be better to use the native implementation instead of wrapping the native implementation in another wrapper (`node:worker_threads`) in another wrapper (`web-worker`)
Owner
|
Thanks for the PR - I just released it as 1.3.0. |
developit
added a commit
that referenced
this pull request
Jan 31, 2025
This adds a `"bun"` package.json `"exports"` condition which loads the browser build in Bun. Bun implements the [Web API `Worker` natively](https://bun.sh/docs/api/workers), and Bun's `node:worker_threads` implementation internally wraps the Web API `Worker`. `web-worker` currently loads the polyfills for Node in Bun (since we must recognize the `"node"` package.json `"exports"` condition for compatibility). This has actually been pretty helpful for catching bugs in our `node:worker_threads` implementation, but it'd be better to use the native implementation instead of wrapping the native implementation in another wrapper (`node:worker_threads`) in another wrapper (`web-worker`) Co-authored-by: Jason Miller <developit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
"bun"package.json"exports"condition which loads the browser build in Bun.Bun implements the Web API
Workernatively, and Bun'snode:worker_threadsimplementation internally wraps the Web APIWorker.web-workercurrently loads the polyfills for Node in Bun (since we must recognize the"node"package.json"exports"condition for compatibility).This has actually been pretty helpful for catching bugs in our
node:worker_threadsimplementation, but it'd be better for our users to use the native implementation instead of wrapping the native implementation in another wrapper (node:worker_threads) in another wrapper (web-worker)