Relative handling, import.meta.url encouragement#5
Merged
Conversation
Closed
developit
reviewed
Apr 14, 2020
developit
approved these changes
Apr 14, 2020
Owner
|
LGTM, figured I'd try to clarify the whole document URL / cwd metaphor, if that's alright. |
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
Collaborator
Author
|
Great... maybe we can get the local tests running in this pattern too then using your Babel trick? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3, supporting non-string inputs into
new Worker(applying toString per the browser), removing the stack hack, and encouraging the use ofimport.meta.urlin the readme.We can likely include a reference to the stack approach in the readme note I've added, where I've called out that test and build support may still be an issue with this pattern. Ideally we could start chasing these up via #4.