Skip to content

Issue 295, (alternate) addresses bug with TSIG verification of large responses #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frankarinnet wants to merge 1 commit into from
Closed

Issue 295, (alternate) addresses bug with TSIG verification of large responses #297

frankarinnet wants to merge 1 commit into from
+35 −9

Conversation

@frankarinnet
Copy link
Contributor

@frankarinnet frankarinnet commented Oct 23, 2023 •
edited
Loading

This is an alternate approach to fixing the large responses TSIG bug (#295) -- really only added for comparison purposes.

Like the other pull request (#296), do not accept without understanding and making some decisions about thread safety.

@frankarinnet frankarinnet mentioned this pull request Oct 23, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

34.6% 34.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@frankarinnet frankarinnet changed the base branch from master to release/3.5.x October 24, 2023 18:56
@frankarinnet frankarinnet changed the base branch from release/3.5.x to master October 24, 2023 18:57
ibauersachs added a commit that referenced this pull request Oct 29, 2023
@ibauersachs @frankarinnet @nguichon
Fix handling of multi-message TSIG responses
36a0c7f 
Closes #295
Closes #297
Closes #298
Closes #299

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
@ibauersachs ibauersachs mentioned this pull request Oct 29, 2023
Merged
@frankarinnet
Copy link
Contributor Author

frankarinnet commented Oct 30, 2023

Added #301 which shows some necessary changes to #300 for adding the signature of the TSIG record at the right time.

ibauersachs added a commit that referenced this pull request Nov 4, 2023
@ibauersachs @frankarinnet @nguichon
Fix handling of multi-message TSIG responses (#300)
c4261b7 
* Fix handling of multi-message TSIG responses

Closes #295
Closes #297
Closes #298
Closes #299

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
@ibauersachs ibauersachs mentioned this pull request Nov 4, 2023
Merged
ibauersachs added a commit that referenced this pull request Nov 4, 2023
@ibauersachs @frankarinnet @nguichon
Fix handling of multi-message TSIG responses (#303)
b575ca8 
* Fix handling of multi-message TSIG responses

Closes #295
Closes #297
Closes #298
Closes #299
Closes #301

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@frankarinnet