fix: doc vec equality #1641
Merged
fix: doc vec equality #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
npitsillos
commented
Jun 12, 2023
- Fixes Bug: Equality of DocVec #1638
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
Signed-off-by: Nikos Pitsillos <npitsillos@gmail.com>
JoanFM
requested changes
Jun 14, 2023
Member
JoanFM
left a comment
There was a problem hiding this comment.
Can u please add tests so that we can approve and merge?
1acdbc1 to
f91f424
Compare
JoanFM
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.