refactor: implementation of InMemoryExactNNIndex follows DBConfig way #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tern Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
cdec987 to
35e108a
Compare
jupyterjazz
reviewed
Jun 14, 2023
Contributor
jupyterjazz
left a comment
There was a problem hiding this comment.
I like this, makes more sense
added 2 commits
June 14, 2023 18:27
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals <joan.martinez@jina.ai>
f19f481 to
f8ce345
Compare
jupyterjazz
approved these changes
Jun 14, 2023
Contributor
jupyterjazz
left a comment
There was a problem hiding this comment.
one small comment and lgtm
f8ce345 to
fc963ea
Compare
jupyterjazz
reviewed
Jun 14, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
fc963ea to
4b97eb4
Compare
|
📝 Docs are deployed on https://ft-fix-in-memory-db-config--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InMemoryExactNNIndexer gets an attribute in
__init__instead of following the pattern of usingDBConfig.Waiting for #1648 to be merged updating Documentation