fix: bugs when serialize union type #1655
Conversation
Signed-off-by: maxwelljin2 <gejin@berkeley.edu>
| ``` | ||
|
|
||
| !!! note | ||
| Currently, union type hints are not supported for serialization to protobuf formats. |
There was a problem hiding this comment.
Any union type? or Union types of regular types are? Can u add tests for the exceptions?
There was a problem hiding this comment.
I'll add more tests. It should be any union type as union type doesn't have the from_protobuf method
Signed-off-by: maxwelljin2 <gejin@berkeley.edu>
|
Currently, the serialization for union type is only supported through |
JoanFM
left a comment
There was a problem hiding this comment.
Still not answered what happens with Union of basic types
|
|
||
| !!! note | ||
| Currently, union type hints are not supported for serialization to protobuf formats. | ||
| Serialization to protobuf formats is not supported for union type hints. Please consider using JSON serialization as an alternative. |
There was a problem hiding this comment.
Avoid the consideration, just inform
|
|
||
| from docarray.documents import TextDoc | ||
|
|
||
| class CustomDoc(BaseDoc): |
There was a problem hiding this comment.
what about Union[int, float] or Union[int, str]
There was a problem hiding this comment.
After the testing, the Union with basic types should work in all serialization methods. Only the Union with document types will cause those issues.
Signed-off-by: maxwelljin2 <gejin@berkeley.edu>
Signed-off-by: maxwelljin2 <gejin@berkeley.edu>
Signed-off-by: Joan Fontanals <jfontanalsmartinez@gmail.com>
This bug is caused by the deserialization process. The deserialization function currently only checks the schema of the class, without specific information about the particular document type in the field of union type. To resolve this issue, we may need to modify the data storage. After discussing with Joan, we could temporarily remove support for the union type and add this info the document. Additionally, we provide users with a more informative error message.