docs: enhance DocVec section #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maxwelljin <101249253+maxwelljin@users.noreply.github.com>
Signed-off-by: maxwelljin <101249253+maxwelljin@users.noreply.github.com>
Signed-off-by: maxwelljin <101249253+maxwelljin@users.noreply.github.com>
JoanFM
requested changes
Jun 19, 2023
README.md
Outdated
|
|
||
| app = FastAPI() | ||
|
|
||
| model_img, model_text = SomeEmbeddingModelImage(), SomeEmbeddingModelText() |
Member
There was a problem hiding this comment.
I prefer to have a def embed_image and def embed_text method with random numpy array generation, it is easier to reproduce
| return doc | ||
|
|
||
|
|
||
| async with AsyncClient(app=app, base_url="http://test") as ac: |
Signed-off-by: maxwelljin <101249253+maxwelljin@users.noreply.github.com>
JoanFM
requested changes
Jun 19, 2023
README.md
Outdated
| app = FastAPI() | ||
|
|
||
| model_img, model_text = SomeEmbeddingModelImage(), SomeEmbeddingModelText() | ||
| model_img, model_text = lambda img: np.zeros((100, 1)), lambda text: np.zeros((100, 1)) |
Member
There was a problem hiding this comment.
lets use a def and not lambda, easier to read
Signed-off-by: maxwelljin <101249253+maxwelljin@users.noreply.github.com>
JoanFM
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates improvements for the document based on Han's suggestions from our Discord channel: