Skip to content

Use anchor instead of building toString() for debug logging #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 1 commit into from
Jun 19, 2023
Merged

Use anchor instead of building toString() for debug logging #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void onNext(BuildResponseItem item) {
} else if (item.isErrorIndicated()) {
this.error = item.getError();
}
LOGGER.debug(item.toString());
LOGGER.debug("{}", item);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion docker-java-api/src/main/java/com/github/dockerjava/api/command/LoadImageCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void onNext(LoadResponseItem item) {
this.error = item.getError();
}

LOGGER.debug(item.toString());
LOGGER.debug("{}", item);
}

public String awaitMessage() {
Expand Down
2 changes: 1 addition & 1 deletion docker-java-api/src/main/java/com/github/dockerjava/api/command/PullImageResultCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void onNext(PullResponseItem item) {
handleDockerClientResponse(item);
}

LOGGER.debug(item.toString());
LOGGER.debug("{}", item);
}

private void checkForDockerSwarmResponse(PullResponseItem item) {
Expand Down
2 changes: 1 addition & 1 deletion ...java-api/src/main/java/com/github/dockerjava/api/command/WaitContainerResultCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class WaitContainerResultCallback extends ResultCallbackTemplate<WaitCont
@Override
public void onNext(WaitResponse waitResponse) {
this.waitResponse = waitResponse;
LOGGER.debug(waitResponse.toString());
LOGGER.debug("{}", waitResponse);
}

/**
Expand Down