-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Support APIs for chunking sources #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
* Add APIs for the /v1/chunk/hierarchical/source endpoint. * Add APIs for the /v1/chunk/hybrid/source endpoint. * Implement new endpoints in reference client. Fixes gh-144 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
edeandrea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I made one small refactoring in DoclingServeClient so we don't have to duplicate/copy-paste the creation of the HttpRequest. Let me know what you think.
Also, what about adding some of these tests to the version tester utility that I built which tests various docling-serve versions?
If these features were introduced in some docling serve version, we can do that too.
See
Lines 50 to 90 in 676a8ed
| private TagTestResult testTag(TagsTestRequest request, String tag) { | |
| var registry = request.registry(); | |
| var image = request.image(); | |
| Log.infof("Testing %s/%s:%s", registry, image, tag); | |
| var resultBuilder = TagTestResult.builder().tag(tag); | |
| var containerConfig = DoclingServeContainerConfig.builder() | |
| .image("%s/%s:%s".formatted(registry, image, tag)) | |
| .startupTimeout(Duration.ofMinutes(5)) | |
| .build(); | |
| try (var doclingContainer = new DoclingServeContainer(containerConfig)) { | |
| try { | |
| doclingContainer.start(); | |
| doConversion(doclingContainer); | |
| resultBuilder.result(Result.success("Tag %s is ok".formatted(tag))); | |
| } | |
| finally { | |
| resultBuilder.serverLogs(doclingContainer.getLogs()); | |
| } | |
| } | |
| catch (AssertionError | Exception ex) { | |
| resultBuilder.result(Result.failure(ex)); | |
| } | |
| finally { | |
| if (request.cleanupContainerImages()) { | |
| // Clean up the image to save on disk space | |
| DockerClientFactory.instance() | |
| .client() | |
| .removeImageCmd(containerConfig.image()) | |
| .withForce(true) | |
| .exec(); | |
| } | |
| } | |
| var result = resultBuilder.build(); | |
| Log.infof("Result [%s] = %s", result.tag(), result.result().status()); | |
| return result; | |
| } |
|
Looks good, thanks! Is it ok if I look into the version tests in a separate PR? |
Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
Sure thing! I have #134 open, so that might help close out that issue. |
Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
🎉 This issue has been resolved in |
Fixes gh-144