Skip to content

Conversation

@ThomasVitale
Copy link
Contributor

  • Add APIs for the /v1/chunk/hierarchical/source endpoint.
  • Add APIs for the /v1/chunk/hybrid/source endpoint.
  • Implement new endpoints in reference client.

Fixes gh-144

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

TestsPassed ✅SkippedFailed
Gradle Test Results (all modules & JDKs)528 ran528 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

* Add APIs for the /v1/chunk/hierarchical/source endpoint.
* Add APIs for the /v1/chunk/hybrid/source endpoint.
* Implement new endpoints in reference client.

Fixes gh-144

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

edeandrea
edeandrea previously approved these changes Dec 4, 2025
Copy link
Contributor

@edeandrea edeandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I made one small refactoring in DoclingServeClient so we don't have to duplicate/copy-paste the creation of the HttpRequest. Let me know what you think.

Also, what about adding some of these tests to the version tester utility that I built which tests various docling-serve versions?

If these features were introduced in some docling serve version, we can do that too.

See

private TagTestResult testTag(TagsTestRequest request, String tag) {
var registry = request.registry();
var image = request.image();
Log.infof("Testing %s/%s:%s", registry, image, tag);
var resultBuilder = TagTestResult.builder().tag(tag);
var containerConfig = DoclingServeContainerConfig.builder()
.image("%s/%s:%s".formatted(registry, image, tag))
.startupTimeout(Duration.ofMinutes(5))
.build();
try (var doclingContainer = new DoclingServeContainer(containerConfig)) {
try {
doclingContainer.start();
doConversion(doclingContainer);
resultBuilder.result(Result.success("Tag %s is ok".formatted(tag)));
}
finally {
resultBuilder.serverLogs(doclingContainer.getLogs());
}
}
catch (AssertionError | Exception ex) {
resultBuilder.result(Result.failure(ex));
}
finally {
if (request.cleanupContainerImages()) {
// Clean up the image to save on disk space
DockerClientFactory.instance()
.client()
.removeImageCmd(containerConfig.image())
.withForce(true)
.exec();
}
}
var result = resultBuilder.build();
Log.infof("Result [%s] = %s", result.tag(), result.result().status());
return result;
}

@ThomasVitale
Copy link
Contributor Author

Looks good, thanks! Is it ok if I look into the version tests in a separate PR?

Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea
Copy link
Contributor

Is it ok if I look into the version tests in a separate PR?

Sure thing! I have #134 open, so that might help close out that issue.

Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
@edeandrea edeandrea enabled auto-merge (squash) December 4, 2025 14:43
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea edeandrea merged commit f99c6b8 into main Dec 4, 2025
20 checks passed
@edeandrea edeandrea deleted the gh-144 branch December 4, 2025 14:53
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@docling-java-ops docling-java-ops bot added the released Issue has been released label Dec 8, 2025
@docling-java-ops
Copy link
Contributor

🎉 This issue has been resolved in v0.2.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Issue has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support APIs for chunking sources

3 participants