fix flush_in_progress not visible to sender#2660
Merged
dpkp merged 2 commits intodpkp:masterfrom Jul 1, 2025
Merged
Conversation
Owner
|
thanks for finding these! |
dpkp
pushed a commit
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call site
kafka-python/kafka/producer/sender.py
Line 285 in 2abf2cd
This is called in Sender._maybe_send_transactional_request(), but over there it's called without
_prefix. Since this method is accessed by other classes I assume we should remove the prefix, instead of making the caller call_flush_in_progressinstead