Expose xhr.withCredentials with correct default#96
Expose xhr.withCredentials with correct default#96driverdan merged 1 commit intodriverdan:masterfrom
Conversation
|
+1 can we merge this in please. |
|
re-reviewed my code change, and all seems good. this is the correct default behavior for XHRs in the browser. ready to merge. |
|
@kumavis Thanks for re-checking it. I just stumbled across this problem in This fails at the moment in jsdom (3.*) because the |
|
@driverdan Please can you merge this into master and build a new release. |
|
📲 come on dan drive it home 🚙 |
|
Can we merge this thing @driverdan? |
|
@novabyte for working XHR in jsdom you can use my patch https://github.com/mareksuscak/jsdom-xhr-patch until this gets resolved and merged. |
Expose xhr.withCredentials with correct default
|
HE LIVES 👻 |
Fixes #71
Replaces #84