Skip to content

Add template instrumentation.#103

Open
rwjblue wants to merge 7 commits intomasterfrom
template-instrumentation
Open

Add template instrumentation.#103
rwjblue wants to merge 7 commits intomasterfrom
template-instrumentation

Conversation

@rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Mar 19, 2017

This PR adds support for instrumentation of templates roughly the same as JS instrumentation (using a custom set of helpers and a template AST transform to instrument templates).

There are still some issues with this approach that we need to vet/review.

  • Need more testing with "real world" templates.
  • Add logic in treeFor to prevent app and addon tree from being emitted unless COVERAGE=true.
  • Figure out how to handle instrumentation of usages of htmlbars-inline-precompiler.
  • Fix issues with istanbul parsing coverage data.
  • Decide if we are willing to do a major version bump, or if we have to rewrite in ES5.

Paired on this with @rondale-sc.

@rwjblue
Copy link
Collaborator Author

rwjblue commented Mar 19, 2017

Decide if we are willing to do a major version bump, or if we have to rewrite in ES5.

@kategengler - Thoughts on this one?

@rwjblue
Copy link
Collaborator Author

rwjblue commented Mar 19, 2017

OK, this is working now. Here is an example after running the test suite of Ember Observer:

screenshot

@kellyselden
Copy link
Collaborator

That's amazing!

@kategengler
Copy link
Collaborator

Seconding amazing!

For:

Decide if we are willing to do a major version bump, or if we have to rewrite in ES5.

I'm fine with a major version bump.

@jrowlingson
Copy link

@rwjblue This does look amazing - any updates?

@RobbieTheWagner
Copy link
Collaborator

@rwjblue how can I help get this across the finish line?

@knownasilya
Copy link

Yes, same thoughts about amazing and how can we get this merged?

Also, would it show coverage for the js side of helpers/components?

@RobbieTheWagner
Copy link
Collaborator

@knownasilya this is likely on hold, due to the new spike. We'll be updating a lot in the coming weeks.

@peabnuts123
Copy link

This looks really nice. Would like to see this make it in 👍

@StevenElberger
Copy link

@kategengler @rwjblue Are there any plans on this being completed soon?

@rwjblue
Copy link
Collaborator Author

rwjblue commented Sep 17, 2020

The general idea here is still valid, just need to complete off the to do items.

@harishv98
Copy link

harishv98 commented May 5, 2021

@rwjblue If this is on hold, is there any way i can contribute and get this merged ?
Really looking forward to use this.

@cah-brian-gantzler
Copy link

Given that template only components are a prevalent thing, this would seem even more important

@mukilane mukilane mentioned this pull request Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.