Skip to content

Added support for in-repo addons #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fushi wants to merge 2 commits into from
Closed

Added support for in-repo addons #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1087b
Added support for in-repo addons
Apr 10, 2017
62601d8
Returning to infinite depth recursion, because it breaks our use case…
Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ module.exports = {
return new BroccoliMergeTrees([tree, instrumentedNode], { overwrite: true });
},

setupPreprocessorRegistry: function() {
var codeCoverageAddon = this;
function iterateAddons(addons) {
addons.forEach(function(addon) {
if (addon.isDevelopingAddon && addon.isDevelopingAddon()) {
addon.addons.push(codeCoverageAddon);
}
iterateAddons(addon.addons);
});
}
iterateAddons(this.project.addons);
},

includedCommands: function () {
return {
'coverage-merge': require('./lib/coverage-merge')
Expand Down Expand Up @@ -143,6 +156,22 @@ module.exports = {
return this._doesTemplateFileExist(relativePath);
},

/**
* Check if a file exists within an in-repo addon
* @param {String} relativePath - path to file
* @returns {Boolean} whether or not the file exists within an in-app addon
*/
_doesFileExistInCurrentProjectInRepoAddons: function(relativePath) {
relativePath = relativePath.split('/').splice(1, 0, 'addon').join('/');
relativePath = path.join('lib', relativePath);

if (this._existsSync(relativePath)) {
return true;
}

return this._doesTemplateFileExist(relativePath);
},

/**
* Check if a template file exists within the current app/addon
* Note: Template files are already compiled into JavaScript files so we must
Expand Down Expand Up @@ -193,7 +222,8 @@ module.exports = {
this._doesFileExistInDummyApp(relativePath) ||
this._doesFileExistInCurrentProjectApp(relativePath) ||
this._doesFileExistInCurrentProjectAddon(relativePath) ||
this._doesFileExistInCurrentProjectAddonModule(relativePath)
this._doesFileExistInCurrentProjectAddonModule(relativePath) ||
this._doesFileExistInCurrentProjectInRepoAddons(relativePath)
);

return !fileExists;
Expand Down