Add mocha support and fix pretender bug#119
Add mocha support and fix pretender bug#119RobbieTheWagner merged 7 commits intoember-cli-code-coverage:masterfrom
Conversation
|
Thanks for working on this, I was just wondering why lcov wasn't regenerating when our mocha tests re-ran on the |
|
I found a different pretender bug....I finally figured out that some of my unit tests weren't tearing mirage down properly by calling |
|
FWIW, pretender throws now if you create a second instance without shutting down the last |
|
Is there anything I need to change about this PR? I noticed that it's failing travis ci builds for node v 0.12 - because ember-cli-htmlbars-inline-precompile isn't transpiled: But I think that's affecting every PR until that version of node is removed from the travis configs. |
|
For what it's worth, #115 drops support for Node 0.12. |
…ode-coverage into add-mocha-support
|
Anybody got any suggestions for the failing tests? When I run them locally with |
|
@mattmarcum Are you running the tests through "npm test", instead of "ember test"? In those specific test cases, "ember test" is run through the node tests. Those EADDRINUSE errors usually occur when a preceeding test fails, and the "ember test" child doesn't exit or hangs, so the next test runs "ember test" and the port is in use. |
|
ok I ran them with |
|
The tests are also fairly flaky, as I've noticed. They can fail intermittently on Travis. |
[Fixes ember-cli-code-coverage#111] Update dependencies, get babel instrumenter working (ember-cli-code-coverage#115) babel 6 fix
…ode-coverage into add-mocha-support
|
Yeah, I squashed my commits and pushed up and now the node v4 tests fail and the node v6 tests pass - the exact opposite of what was happening before - no code changes. |
|
@mattmarcum seems the tests are a bit flaky, but I restarted them and they passed 🎉 . Going to go ahead and merge this in. |
This should address #2 and also fixes a bug I was seeing with the pretender passthrough/fake request not having a
responseproperty.