Thanks for this @adamjmcgrath! Somehow I just noticed this. Will try to take a look at this soon.

@adamjmcgrath I spoke with @rwjblue and he thinks this looks pretty good, so definitely some more tests and some docs would be great 😄 . Please let me know what you need help with and I'm happy to jump in.

Sounds good thanks, will take a look at this in the week

Have made some updates:

• Taken out my suggested changes for the parallel option (will raise another PR for that)
• Remove test fixtures when this addon is being consumed
• Added some unit tests for the new instrumentation logic
• Couple of small updates to the docs

Thanks @adamjmcgrath! @rwjblue do you have time to do a quick review on this?

@adamjmcgrath should we add something to the docs about configuring with .istanbul.yml? I believe that is the path forward, versus maintaining a separate config here, right?

@adamjmcgrath should we add something to the docs about configuring with .istanbul.yml? I believe that is the path forward, versus maintaining a separate config here, right?

@rwwagner90 Yes, although you would currently still need to declare excludes, reporters and coverageFolder in the addon's config file.

excludes config could just be removed in favour of using .istanbul.yml. But in order to remove reporters and coverageFolder from the addon config there would need to be a change to how parallel works (which I intend to propose in another PR).

Thanks for adding the docs! This seems fine to me. I would like @rwjblue to take a quick look before we merge though.

I ran this locally against some of my apps and addons and it seems to more or less work. This is a huge improvement from the previous version, as before it did not work at all with newer ES features like async/await. Going to go ahead and merge. Thanks so much for the PR @adamjmcgrath! If you are interested in helping out more, I could use some help going through the open issues and seeing what has been fixed by this PR and what we still need to implement.

If you are interested in helping out more, I could use some help going through the open issues and seeing what has been fixed by this PR and what we still need to implement.

@rwwagner90 sure - I'm happy to help out. Will have a look through the open issues this week.