adds coverage support for transpiled javascript source#146
adds coverage support for transpiled javascript source#146theseyi wants to merge 5 commits intoember-cli-code-coverage:masterfrom
Conversation
theseyi
commented
Nov 27, 2017
- this should resolve Does not work with CoffeeScript #55
- coverage is instrumented for transpiled sources
|
what's the status of this ? this allows coverage on .ts files, that was not possible earlier. would love to see this merged |
|
@adamjmcgrath do the new betas support transpiled sources? Typescript, Coffeescript, etc? If not, what would it take to land some of the tweaks from this PR? |
I just tested this on https://github.com/dfreeman/why-yes-i-do-have-types I had to add But after that it seemed to work ok (not sure why I would have thought, that for an |
|
@adamjmcgrath could we expose a config option to pass the extensions to report coverage for, like this PR did? |
😆 glad that's getting some use
We're doing some kind of odd things in ember-cli-typescript, but I think if we associate the Update: opened #164 here and typed-ember/ember-cli-typescript#144 to get this working end-to-end. |
|
@dfreeman so this all works with typescript now, right? Can we close this? |
|
@rwwagner90 with |
|
@dfreeman I would consider that another bug. Do you mind opening an issue with the details and a screenshot of what you observed please? I am closing this issue for now. |
