Skip to content

Comments

Revert "Remove merge-coverage and explicit parallel option (#163)"#166

Merged
kategengler merged 2 commits intomasterfrom
revert-pr-163
Mar 24, 2018
Merged

Revert "Remove merge-coverage and explicit parallel option (#163)"#166
kategengler merged 2 commits intomasterfrom
revert-pr-163

Conversation

@adamjmcgrath
Copy link
Collaborator

This reverts commit 0592f5f.

Reverting because PR #163 removed support for merging coverage reports generated after separate test runs, eg when using the partition feature of ember exam

@kategengler
Copy link
Collaborator

@adamjmcgrath Sorry for letting this linger. I think the improvements from the work this reverts to combine coverage as it comes in are great, but we just need to also have the parallel option and coverage-merge command for those using it in a partition. Do you want to update this PR to just bring back those parts?

@adamjmcgrath
Copy link
Collaborator Author

Do you want to update this PR to just bring back those parts?

Sure - no problem. Will do that this week

@kategengler kategengler merged commit d234882 into master Mar 24, 2018
@kategengler
Copy link
Collaborator

Thanks for bringing it back!

@RobbieTheWagner RobbieTheWagner deleted the revert-pr-163 branch April 26, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants