Module unification support by abhilashlr · Pull Request #198 · ember-cli-code-coverage/ember-cli-code-coverage

abhilashlr · 2018-09-22T11:01:42Z

What this PR does?
Fix for #197

Partial support for module unification based folder structure.
Coverage takes -test.js files that are part of the individual folders. (Needs help)
Add readme

RobbieTheWagner · 2018-09-22T14:11:23Z

@kategengler do you have any insights on the items marked as needs help for this PR? I haven't tried using MU myself, and wanted to get your input, since you are likely more familiar with all the changes that would be necessary here and the inner workings on MU apps.

kategengler · 2018-09-22T15:29:08Z

I'm not sure. I'll investigate.

NullVoxPopuli · 2018-10-05T10:50:26Z

I'm not sure if I've configured something wrong with sourcemaps, but my line annotations are way off

abhilashlr · 2018-10-06T08:42:10Z

@NullVoxPopuli are tests running twice for you as well?

NullVoxPopuli · 2018-10-06T11:34:21Z

I think things are only running once for me

NullVoxPopuli · 2018-10-06T11:35:19Z

proof: https://gitlab.com/NullVoxPopuli/emberclear/-/jobs/105285122

abhilashlr · 2018-10-06T17:13:41Z

@rwwagner90 @kategengler Looks like all the points are addressed now. Travis seems to fail and should be fixed by #202

RobbieTheWagner · 2018-10-07T23:23:44Z

@abhilashlr the master branch is passing with babel 7, we would need the same to be true here.

abhilashlr · 2018-10-18T18:50:56Z

@rwwagner90 there is no change in this PR with respect to ember-cli-babel. Can you please help me in resolving that issue if so?

RobbieTheWagner · 2018-10-19T12:20:24Z

@abhilashlr yes, I can help debug. Aside from the test issues right now, does this correctly report coverage for your MU project?

abhilashlr · 2018-10-19T17:54:58Z

@rwwagner90 yes it does report them correctly.

NullVoxPopuli · 2018-10-19T18:14:28Z

@abhilashlr, you don't have issues with highlighting accuracy? Maybe I configured typescript wrong. Hmm

abhilashlr · 2018-10-19T18:59:02Z

Nope @NullVoxPopuli, In my sample app that has MU without typescript, highlight seems fine.

…e-coverage into Module_Unification

NullVoxPopuli · 2018-11-13T10:58:36Z

if someone could review the configuration of my typescript setup, that'd be great... cause something is off.

tsconfig:

{
  "compilerOptions": {
    "target": "ES2017",
    "allowJs": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "noEmitOnError": false,
    "noEmit": true,
    "inlineSourceMap": true,
    "inlineSources": true,
    "noImplicitAny": true,
    "noImplicitThis": true,
    "noImplicitReturns": false,
    "alwaysStrict": true,
    "strictNullChecks": true,
    "strictPropertyInitialization": true,
    "noFallthroughCasesInSwitch": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "baseUrl": ".",
    "module": "es6",
    "paths": {
      "emberclear/config/*": [
        "config/*"
      ],
      "emberclear/tests/*": [
        "tests/*"
      ],
      "emberclear/*": [
        "src/*"
      ],
      "emberclear/src/*": [
        "src/*"
      ],
      "*": [
        "types/*"
      ],
      "@ember": [
        "node_modules/@types/ember/index.d.ts"
      ],
      "fetch": [
        "node_modules/ember-fetch/index.d.ts"
      ],
      "tweetnacl": [
        "node_modules/tweetnacl/nacl.d.ts"
      ]
    }
  },
  "include": [
    "src",
    "tests",
    "types"
  ]
}

ember-cli-babel.js

  let app = new EmberApp(defaults, {
    hinting: false,
    minifyJS: { enabled: false },
    minifyCSS: { enabled: isProduction },


    babel: {
      sourceMaps: 'inline'
    //   plugins: [
    //     ['@babel/plugin-syntax-decorators', { legacy: true }]
    //   ]
    },

    sourcemaps: {
      enabled: !isProduction,
      extensions: 'js'
    },

    'ember-cli-babel': {
      includePolyfill: false,
      disablePresetEnv: true,
      disableDebugTooling: isProduction,
      // Will not build if uncommented:
      // disableEmberModulesAPIPolyfill: true
      // compileModules: false,
    },
// ...

and I'm running coverage with:

COVERAGE=true yarn test

where test is defined as:

    "test": "yarn ember exam --random",

and my coverage report looks like this:

the highlighting is super weird -- partial word highlighting and such..
it looks like the line-hit counts are correct, or at least align with things that make sense.

So, what have I missed it configuration? or is something wrong?

I'm using these versions of things:

$ yarn outdated
yarn outdated v1.12.3
info Color legend : 
 "<red>"    : Major Update backward-incompatible updates 
 "<yellow>" : Minor Update backward-compatible features 
 "<green>"  : Patch Update backward-compatible bug fixes
Package                 Current      Wanted Latest Package Type    URL                                                                                                 
ember-cli               3.5.0        exotic exotic devDependencies github:ember-cli/ember-cli#6e84ea4da023960f89404a781375223e6c833609                                 
ember-cli-babel         6.17.2       6.17.2 7.1.3  devDependencies git://github.com/babel/ember-cli-babel.git                                                          
ember-cli-code-coverage 1.0.0-beta.6 exotic exotic devDependencies abhilashlr/ember-cli-code-coverage#Module_Unification                                               
ember-data              3.5.0        exotic exotic devDependencies github:emberjs/data#8b7de9e69f2418ef9747aa4ca51f59efff9d669c                                        
ember-router-helpers    0.2.0        exotic exotic devDependencies github:rwjblue/ember-router-helpers                                                                 
ember-service-worker    0.7.0        exotic exotic devDependencies github:DockYard/ember-service-worker#c78cb28432af5eeb6e4adc0961fb7f8da025cd14                       
ember-source            3.6.0-canary exotic exotic devDependencies https://s3.amazonaws.com/builds.emberjs.com/canary/shas/a662910a5ce72ce84ba8867a5abfcf1b30158dcf.tgz
libsodium               0.7.3        exotic exotic dependencies    github:jedisct1/libsodium.js#8fa117918df38f52668feaf9cbc498c633671855                               
libsodium               0.7.3        exotic exotic dependencies    github:jedisct1/libsodium.js#8fa117918df38f52668feaf9cbc498c633671855                               
qr-scanner              0.4.0        exotic exotic dependencies    github:nimiq/qr-scanner                                                                             
Done in 2.01s.

NullVoxPopuli · 2018-11-13T18:27:13Z

@abhilashlr looks like my tests are running twice:
#204 (comment)

I ran them with

$ COVERAGE=true yarn start:dev
yarn run v1.12.3
$ SW_DISABLED=true FASTBOOT_DISABLED=true yarn start -p 4201
$ yarn ember serve -p 4201 -p 4201
$ EMBER_CLI_MODULE_UNIFICATION=true node_modules/.bin/ember serve -p 4201 -p 4201

(looks like I have a duplicate port specification, oops)

NullVoxPopuli · 2019-01-07T15:29:22Z

can this be rebased? I'm using babel7 now, and this branch no longer works

RobbieTheWagner · 2019-01-07T19:45:26Z

@NullVoxPopuli I resolved the conflict, but not sure if that also will update the other things.

NullVoxPopuli · 2019-01-07T19:53:53Z

hmm, something is still wrong. I'm still getting failures with coverage enabled. :-\

RobbieTheWagner · 2019-01-07T22:23:31Z

@NullVoxPopuli I am not sure how to rebase this, since it is from @abhilashlr's fork.

AvremelM · 2019-01-07T22:49:57Z

@NullVoxPopuli Perhaps try my fork? It won't rebase this PR, but it'll tell you if rebasing makes it work for you.

NullVoxPopuli · 2019-01-08T10:33:11Z

@HodofHod almost: https://gitlab.com/NullVoxPopuli/emberclear/-/jobs/142813613

now it looks like coverage-merge doesn't seem to work :(

I guess because coverage just isn't tracked now?
I checked one of the individual coverage reports

abhilashlr · 2019-02-23T02:56:04Z

Is there something that needs to be worked on this further? Please let me know

NullVoxPopuli · 2019-02-23T03:06:13Z

I guess, it just needs to work against this: https://github.com/ember-cli/ember-octane-blueprint/

my emberclear code may have something else going on, with typescript being involved and everything.

Just need two smoke tests, I guess: Octane: js + ts (e-c-ts@2)

NullVoxPopuli · 2019-08-29T14:24:02Z

MU, as we know it, has been descoped. This should probs be closed

RobbieTheWagner · 2019-08-29T16:48:06Z

@NullVoxPopuli it will still eventually happen, supposedly, so couldn't hurt to keep this around for a bit.

lstrzebinczyk · 2019-12-28T13:59:14Z

Module unification is now dead, isn't it?

NullVoxPopuli · 2019-12-28T14:04:36Z

yup.

RobbieTheWagner · 2019-12-28T14:22:22Z

Closing since MU is dead

abhilashlr and others added 3 commits September 22, 2018 12:37

Module unification support

56e1c7f

Update readme with a note

e77e7c1

Merge branch 'master' into Module_Unification

40e8845

RobbieTheWagner requested a review from kategengler September 22, 2018 14:10

This was referenced Oct 5, 2018

template instrumentation (merged master) #200

Merged

Module unification updates #201

Closed

exclude co-located tests (#1)

a47f147

abhilashlr closed this Oct 18, 2018

abhilashlr reopened this Oct 18, 2018

Merge branch 'master' of https://github.com/kategengler/ember-cli-cod…

44fabec

…e-coverage into Module_Unification

Merge branch 'master' into Module_Unification

167b52e

RobbieTheWagner closed this Dec 28, 2019

abhilashlr deleted the Module_Unification branch January 19, 2020 11:10

Conversation

abhilashlr commented Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobbieTheWagner commented Sep 22, 2018

Uh oh!

kategengler commented Sep 22, 2018

Uh oh!

NullVoxPopuli commented Oct 5, 2018

Uh oh!

abhilashlr commented Oct 6, 2018

Uh oh!

NullVoxPopuli commented Oct 6, 2018

Uh oh!

NullVoxPopuli commented Oct 6, 2018

Uh oh!

abhilashlr commented Oct 6, 2018

Uh oh!

RobbieTheWagner commented Oct 7, 2018

Uh oh!

abhilashlr commented Oct 18, 2018

Uh oh!

RobbieTheWagner commented Oct 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhilashlr commented Oct 19, 2018

Uh oh!

NullVoxPopuli commented Oct 19, 2018

Uh oh!

abhilashlr commented Oct 19, 2018

Uh oh!

NullVoxPopuli commented Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli commented Nov 13, 2018

Uh oh!

NullVoxPopuli commented Jan 7, 2019

Uh oh!

RobbieTheWagner commented Jan 7, 2019

Uh oh!

NullVoxPopuli commented Jan 7, 2019

Uh oh!

RobbieTheWagner commented Jan 7, 2019

Uh oh!

AvremelM commented Jan 7, 2019

Uh oh!

NullVoxPopuli commented Jan 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhilashlr commented Feb 23, 2019

Uh oh!

NullVoxPopuli commented Feb 23, 2019

Uh oh!

NullVoxPopuli commented Aug 29, 2019

Uh oh!

RobbieTheWagner commented Aug 29, 2019

Uh oh!

lstrzebinczyk commented Dec 28, 2019

Uh oh!

NullVoxPopuli commented Dec 28, 2019

Uh oh!

RobbieTheWagner commented Dec 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

abhilashlr commented Sep 22, 2018 •

edited

Loading

RobbieTheWagner commented Oct 19, 2018 •

edited

Loading

NullVoxPopuli commented Nov 13, 2018 •

edited

Loading

NullVoxPopuli commented Jan 8, 2019 •

edited

Loading