Conversation
8dd0676 to
83887fb
Compare
rwjblue
commented
May 27, 2020
|
|
||
| var request = new XMLHttpRequest(); | ||
| request.open('POST', '/write-coverage', REQUEST_ASYNC); | ||
| request.open('POST', '/write-coverage'); |
Collaborator
Author
There was a problem hiding this comment.
XHR's .open method defaults to async if not given a value of false for the 3rd argument.
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/open
Unfortunately, this codepath is not under test and the changes from a prior PR left it in an invalid state. * The REQUEST_ASYNC variable was no longer present, and therefore referencing it threw an error * The guard around `xhr.responseText` was no longer needed (we only ever get `JSON`, and `xhr.response` is already parsed properly for us) We ultimately need to refactor to get this coverage reporting under test (plausibly an end-to-end acceptance test that confirms the expected JSON reporter output after running all the tests).
83887fb to
cc22041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, this codepath is not under test and the changes from #251 left it in an invalid state.
xhr.responseTextwas no longer needed (we only ever getJSON, andxhr.responseis already parsed properly for us)We ultimately need to refactor to get this coverage reporting under test (plausibly an end-to-end acceptance test that confirms the expected JSON reporter output after running all the tests).