Add test for files in app directory of in-repo addons#345
Merged
rwjblue merged 1 commit intoember-cli-code-coverage:masterfrom Dec 2, 2021
Merged
Conversation
Collaborator
|
Thank you!!! |
rwjblue
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to confirm
modifyAssetLocationworks as expected when not using the--pathoption. I cherry-picked this from #342 and usedmodifyAssetLocationto make the tests pass. The example in the readme wasn't sufficient though, as therelativePathdoesn't start withapp, but with the project name (as this is not replaced by thenamespaceMappingyet at this point), so I adjusted the readme to make this more clear.