Skip to content

Added ability to pass coverage api value and report type from client app config#366

Open
saloniy wants to merge 5 commits intoember-cli-code-coverage:masterfrom
saloniy:master
Open

Added ability to pass coverage api value and report type from client app config#366
saloniy wants to merge 5 commits intoember-cli-code-coverage:masterfrom
saloniy:master

Conversation

@saloniy
Copy link

@saloniy saloniy commented Nov 17, 2022

Added the ability to pass the value of the API from the client application instead of using write-coverage always as discussed.
The default will be set to write-coverage just in case the value is not passed from the client app.
Tested this with my app and it's working as expected after adding the coverageApiPath in my app's config/coverage.js
image

@saloniy saloniy marked this pull request as draft November 17, 2022 20:34
@saloniy saloniy marked this pull request as ready for review November 23, 2022 18:31
@saloniy saloniy changed the title Added ability to pass coverage api value from client app config Added ability to pass coverage api value and report type from client app config Nov 25, 2022
@rwjblue rwjblue requested a review from kategengler January 10, 2023 16:10
@krasnoukhov
Copy link
Contributor

This looks useful to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants