remove unused @embroider/core dependency#378
Closed
mansona wants to merge 1 commit intoember-cli-code-coverage:masterfrom
Closed
remove unused @embroider/core dependency#378mansona wants to merge 1 commit intoember-cli-code-coverage:masterfrom
mansona wants to merge 1 commit intoember-cli-code-coverage:masterfrom
Conversation
Collaborator
Author
|
Turns out it's not as simple as that 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really see where
@embroider/coreis being used even though it's a dependency of this package 🤔 I have run the tests after removing the dependency and it seems to work fine 🎉I noticed this when I was trying to try out the new unstable release of embroider and pnpm wasn't allowing me to update because it didn't match the version defined in this package. I figured if it's not being used the best solution is to remove it 👍