Handle relative paths when fixing keys#390
Merged
RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom Nov 7, 2023
Merged
Handle relative paths when fixing keys#390RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom
RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom
Conversation
Contributor
|
@wagenet what is up with the test failures? |
Contributor
Author
|
@kiwiupover looks like there's a bug for the embroider case. I believe I've fixed it now, but we should note that the embroider case is actually currently testing that we get no coverage metrics! This certainly seems wrong, but should be addressed in another PR. |
RobbieTheWagner
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a mono repo with v2-style in-repo addons and tests. For instance, we have
ROOT/addons/internalandROOT/tests/internal. The path relative to our tests end up looking like../../addons/internal. Without the new conditional, we'd end up hitting the fallback case which tries to make everything relative totests/internal/appthis would end up getting translated intoROOT/tests/addons/internalwhich is not the correct path. I believe it should always be correct to pass relative paths through as-is, which is what I've done here. This solves the problem for our uses.