Switch to pnpm for Workspace Management and Tests Refactoring.#398
Merged
RobbieTheWagner merged 3 commits intoember-cli-code-coverage:masterfrom Nov 14, 2023
Merged
Switch to pnpm for Workspace Management and Tests Refactoring.#398RobbieTheWagner merged 3 commits intoember-cli-code-coverage:masterfrom
RobbieTheWagner merged 3 commits intoember-cli-code-coverage:masterfrom
Conversation
d1a2e2e to
7d77822
Compare
Contributor
Author
|
Not quite what I had in mind. Despite my efforts to maximize the speed of the embroider tests. Replacing dependencies necessitates reinstalling them, which is still quite time-consuming. At least it's consistent. |
Contributor
Author
|
Here's the summary of my changes:
|
RobbieTheWagner
approved these changes
Nov 14, 2023
Collaborator
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This is awesome, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RobbieTheWagner I started to work on the pnpm conversion. But i have a few questions considering the tests.
Should we consider keeping the test applications on Ember 3.x, or is it advisable to update them to at least the lowest LTS release (4.4)?
Should we drop the support of old Embroider versions (<= 1.0.0) ?
Perhaps we should explore alternative methods for testing these test-apps, allowing for isolation from each other, and potentially enabling concurrent launches with varying dependency versions. Similar to what ember-try does.
I tried adding the test packages in the workspace, but the tests for the Embroider app are failing 50% of the time. I'll try again later.