Skip to content

Fix serverMiddleware for development mode #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 2 commits into from
Apr 25, 2024
Merged

Fix serverMiddleware for development mode #413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ded7909
Fix serverMiddleware for development mode
krasnoukhov Apr 5, 2024
627912d
fix lint
krasnoukhov Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions packages/ember-cli-code-coverage/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,20 +143,26 @@ module.exports = {
* If coverage is enabled attach coverage middleware to the express server run by ember-cli
* @param {Object} startOptions - Express server start options
*/
serverMiddleware(startOptions, config) {
attachMiddleware.serverMiddleware(startOptions.app, config);
serverMiddleware(startOptions) {
attachMiddleware.serverMiddleware(
startOptions.app,
this._middlewareConfig()
);
},

testemMiddleware(app) {
const config = {
// if we're running `ember test --server` use the `serverMiddleware`.
if (process.argv.includes('--server') || process.argv.includes('-s')) {
return this.serverMiddleware({ app });
}
attachMiddleware.testMiddleware(app, this._middlewareConfig());
},

_middlewareConfig() {
return {
configPath: this.project.configPath(),
root: this.project.root,
namespaceMappings: this.buildNamespaceMappings(),
};
// if we're running `ember test --server` use the `serverMiddleware`.
if (process.argv.includes('--server') || process.argv.includes('-s')) {
return this.serverMiddleware({ app }, config);
}
attachMiddleware.testMiddleware(app, config);
},
};