Updating the README to callout interim solution in test-helper.js#423
Open
cah-john-ryan wants to merge 1 commit intoember-cli-code-coverage:masterfrom
Open
Updating the README to callout interim solution in test-helper.js#423cah-john-ryan wants to merge 1 commit intoember-cli-code-coverage:masterfrom
cah-john-ryan wants to merge 1 commit intoember-cli-code-coverage:masterfrom
Conversation
kategengler
reviewed
Sep 5, 2024
| forceModulesToBeLoaded(); | ||
| await sendCoverage(); | ||
| }); | ||
| if (config.APP.isRunningWithServerArgs) { |
Collaborator
There was a problem hiding this comment.
The README would also need to indicate where to set this
Author
There was a problem hiding this comment.
Hi Kate, thanks for catching that. I have added another section above test-helpers.js in the README to callout the config setting being leveraged.
I am not sure I agree with the existing format for the file edits and how easy it is to identify the changes a user would need to apply. If you have any suggestions on further changes let me know and I will be happy to try and apply them.
1550c8f to
27c5786
Compare
27c5786 to
76d24a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to address the concerns called out in issue #422