Skip to content

Fixes the hanging issue of #88 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellyselden merged 2 commits into from
Jun 27, 2017
Merged

Fixes the hanging issue of #88 #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2ecaa
Refactor onload to onreadystatechange
ming-codes Jan 7, 2017
eda9a2c
Fix PhantomJS honoring responseType issue
ming-codes Jan 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/templates/test-body-footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@

if (REQUEST_ASYNC) {
request.responseType = 'json';
request.onload = function() {
handleCoverageResponse(this, callback);
}
request.onreadystatechange = function() {
if (request.readyState === 4) {
handleCoverageResponse(this, callback);
}
};
} else {
// The request is already done at this point, since it is synchronous
if (request.status === 200) {
Expand All @@ -47,7 +49,7 @@
}

function handleCoverageResponse(xhr, callback) {
var data = xhr.response;
var data = xhr.response || xhr.responseText;

// PhantomJS doesn't honor `responseType = 'json'`
if (typeof data === 'string') {
Expand Down