Nested folder for ember coverage-merge#93
Merged
RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom Sep 29, 2017
Merged
Nested folder for ember coverage-merge#93RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom
RobbieTheWagner merged 2 commits intoember-cli-code-coverage:masterfrom
Conversation
ddc6013 to
673833c
Compare
Collaborator
|
@designblooz sorry for the delay in reviewing this! I merged master into this PR and the tests appear to be failing. Would you mind taking a look please? |
691c214 to
307f31e
Compare
307f31e to
3a702aa
Compare
Contributor
Author
|
@rwwagner90 fixed failing test |
Collaborator
|
Thanks @designblooz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is intended or not, but
ember coverage-mergedoes not work whencoverageFolderis nested.matchDiroption fornode-dironly works for direct child folders of root folder.