P2P bootstrapping by tzdybal · Pull Request #14 · evstack/ev-node

tzdybal · 2021-02-27T12:09:22Z

First step in implementation of P2P layer will be connection bootstrapping.

Node private key will be generated and provided by cosmos-sdk.

This work is related to #2.

codecov-io · 2021-02-27T12:10:54Z

Codecov Report

Merging #14 (aa83491) into main (363cec3) will increase coverage by 72.09%.
The diff coverage is 72.09%.

@@            Coverage Diff            @@
##           main      #14       +/-   ##
=========================================
+ Coverage      0   72.09%   +72.09%     
=========================================
  Files         0        3        +3     
  Lines         0       43       +43     
=========================================
+ Hits          0       31       +31     
- Misses        0        6        +6     
- Partials      0        6        +6

Impacted Files	Coverage Δ
p2p/client.go	`62.96% <62.96%> (ø)`
conv/crypto.go	`80.00% <80.00%> (ø)`
conv/config.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363cec3...aa83491. Read the comment docs.

liamsi · 2021-02-28T22:24:33Z

node/node.go

We should at least consider if doesn't make more sense, to directly generate a libp2p/crypto key in startInProcess and pass it into optimint directly instead. It seems like we have to modify that file (server/start.go) in the sdk anyway. For now that shouldn't matter to much until we have a clearer picture of the other changes in the sdk (if any).

Very good comment. I was focusing on minimizing changes in cosmos-sdk, but probably I went to far.
Created tracking issue for this: #15.

Libp2p private key is added to Node struct. Constructor accepts NodeKey (from Tendermint) because it is used by cosmos-sdk.

It was a placeholder from initial commit.

Type conversion from Tendermint/cosmos-sdk to libp2p/Optimint types is extracted to `conv` package. Conversion functions can be used directly in SDK, so Optimint is called with proper types, API is not cluttered with different types.

This is just a beginning, more fields will be added as needed.

liamsi · 2021-03-04T23:08:29Z

So nice to see this coming together! Can you briefly explain what the current scope of this PR is? As far as I understand, it connects to a bunch of seed (aka bootstrap) nodes?

liamsi · 2021-03-04T23:09:16Z

p2p/client.go

+	var err error
+	var p2pId multiaddr.Multiaddr
+	if at := strings.IndexRune(addr, '@'); at != -1 {
+		p2pId, err = multiaddr.NewMultiaddr("/p2p/" + addr[:at])


/p2p/ ~~Is that really a valid MultiAddr?~~ NVM, it's valid. I need to go and read more about multiaddrs myslef. preferred over /ipfs is not a really helpful description of the protocol here: https://github.com/multiformats/multiaddr/blob/master/protocols.csv

/p2p is something we can use without "registering" protocol, and it supports IDs - it's basically what we need, without reinventing the wheel.

liamsi · 2021-03-04T23:22:23Z

p2p/client_test.go

+		{"ip only", "127.0.0.1", nil, ErrInvalidAddress.Error()},
+		{"with invalid id", "deadbeef@127.0.0.1:1234", nil, "failed to parse multiaddr"},
+		{"valid", "127.0.0.1:1234", valid, ""},
+		{"valid with id", "k2k4r8oqamigqdo6o7hsbfwd45y70oyynp98usk7zmyfrzpqxh1pohl7@127.0.0.1:1234", withId, ""},


Thinking about this further: While it is right that SDK users will be used to the "@-format", we will likely use the public libp2p bootstrap nodes for some first actual experiments (let's say you and me want to run a node and see if they find each other). Then, we would go find the libp2p bootstrap nodes, translate those addrs to the @-format to use them in the local config, only for them to be translated back to the original format. So maybe we should actually just use the libp2p-style addrs directly 🤔

evan-forbes · 2021-03-05T19:38:37Z

Just to make sure I'm understanding everything, the libp2p host.Host handles the "service" in the background for us and we just have to connect nodes via bootstrap, correct?

tzdybal · 2021-03-05T22:17:44Z

@evan-forbes yes, host does all the heavy lifting. We still need static list of nodes, so we can begin peer discovery (I'm working on/debugging it in #17).

evan-forbes · 2021-03-06T02:31:25Z

p2p/client_test.go

+	t.Parallel()
+
+	valid := mustGetMultiaddr(t, "/ip4/127.0.0.1/tcp/1234")
+	withId := mustGetMultiaddr(t, "/ip4/127.0.0.1/tcp/1234/p2p/k2k4r8oqamigqdo6o7hsbfwd45y70oyynp98usk7zmyfrzpqxh1pohl7")


What is this address? It's in the multiaddr repo too.

I just used some example to from multiaddr repo to ensure that this address is valid.

evan-forbes

I appreciate how strictly contained this PR is, and learned a thing or two about libp2p. LGTM 👍

liamsi

Looks like a solid start! We might want to reconsider "translating" between tendermint / SDK node.IDs and libp2p IDs. This will be discussed in #16 .

tzdybal requested a review from liamsi February 27, 2021 12:09

tzdybal changed the base branch from main to tzdybal/abci_methods February 27, 2021 12:09

tzdybal mentioned this pull request Feb 27, 2021

Optimint - P2P bootstrapping celestiaorg/cosmos-sdk#23

Merged

liamsi reviewed Feb 28, 2021

View reviewed changes

tzdybal mentioned this pull request Mar 1, 2021

Consider preparing native optimint arguments in cosmos-sdk #15

Closed

tzdybal changed the base branch from tzdybal/abci_methods to main March 1, 2021 09:05

tzdybal added 2 commits March 1, 2021 10:07

Add private key to Node

f5ab637

Libp2p private key is added to Node struct. Constructor accepts NodeKey (from Tendermint) because it is used by cosmos-sdk.

Remove unused file.

504f90f

It was a placeholder from initial commit.

tzdybal force-pushed the tzdybal/p2p/bootstrapping branch from faf5e50 to 504f90f Compare March 1, 2021 09:07

tzdybal added 3 commits March 1, 2021 12:05

Accept libp2p key type in Node constructor

d3d534e

Type conversion from Tendermint/cosmos-sdk to libp2p/Optimint types is extracted to `conv` package. Conversion functions can be used directly in SDK, so Optimint is called with proper types, API is not cluttered with different types.

Add Node config and config conversion

a58b55b

This is just a beginning, more fields will be added as needed.

Add ListenAddress configuration option

0702753

tzdybal marked this pull request as ready for review March 3, 2021 10:31

tzdybal requested review from evan-forbes and liamsi March 3, 2021 10:32

liamsi reviewed Mar 4, 2021

View reviewed changes

evan-forbes reviewed Mar 6, 2021

View reviewed changes

evan-forbes approved these changes Mar 6, 2021

View reviewed changes

tzdybal mentioned this pull request Mar 9, 2021

Node address format #16

Closed

liamsi approved these changes Mar 9, 2021

View reviewed changes

tzdybal added 4 commits March 9, 2021 14:25

Initialization of P2P network client

ca96412

Client startup sanity check

a0701dc

Node ID parsing, sentinel errors

229368b

Bootstrapping test

bb1da59

tzdybal force-pushed the tzdybal/p2p/bootstrapping branch from 63118f1 to bb1da59 Compare March 9, 2021 13:28

tzdybal merged commit f7a551f into main Mar 9, 2021

liamsi deleted the tzdybal/p2p/bootstrapping branch March 9, 2021 13:31

claude bot mentioned this pull request Oct 9, 2025

fix(block/syncing): save data to p2p stores #2736

Merged

This was referenced Nov 19, 2025

feat: High availabilty via RAFT #2836

Closed

feat: forced inclusion #2797

Merged

claude bot mentioned this pull request Nov 26, 2025

refactor: update cliento to blob api and remove core da #2887

Closed

This was referenced Dec 3, 2025

feat(evm): add force inclusion command #2888

Merged

feat: DA Client remove interface part 3, replace types with new code #2910

Merged

This was referenced Dec 11, 2025

feat: p2p exchange wrapper #2855

Merged

feat(syncing): add grace period for missing force txs inclusion #2915

Merged

This was referenced Dec 18, 2025

fix(block): fix init logic sequencer for da epoch fetching #2926

Merged

fix: make evm_execution more robust #2942

Merged

claude bot mentioned this pull request Jan 5, 2026

feat(block): async epoch fetching #2952

Merged

This was referenced Jan 29, 2026

fix(cache,store): improve cache handling #3030

Merged

refactor(cache)!: remove gob cache #3047

Merged

feat: block Pruning #2984

Merged

Conversation

tzdybal commented Feb 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

liamsi Feb 28, 2021

Choose a reason for hiding this comment

Uh oh!

tzdybal Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

liamsi commented Mar 4, 2021

Uh oh!

liamsi Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tzdybal Mar 5, 2021

Choose a reason for hiding this comment

Uh oh!

liamsi Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

evan-forbes commented Mar 5, 2021

Uh oh!

tzdybal commented Mar 5, 2021

Uh oh!

evan-forbes Mar 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tzdybal Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

evan-forbes left a comment

Choose a reason for hiding this comment

Uh oh!

liamsi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

tzdybal commented Feb 27, 2021 •

edited

Loading

codecov-io commented Feb 27, 2021 •

edited

Loading

liamsi Mar 4, 2021 •

edited

Loading

evan-forbes Mar 6, 2021 •

edited

Loading

liamsi left a comment •

edited

Loading