Skip to content

Comments

fix: verify if MaxBytes is less than or equal to 0#1770

Merged
tzdybal merged 1 commit intoevstack:mainfrom
Eoous:verify_max_bytes
Jul 16, 2024
Merged

fix: verify if MaxBytes is less than or equal to 0#1770
tzdybal merged 1 commit intoevstack:mainfrom
Eoous:verify_max_bytes

Conversation

@Eoous
Copy link
Contributor

@Eoous Eoous commented Jul 11, 2024 •
edited by tzdybal
Loading

Overview

This PR verifies if MaxBytes is less than or equal to 0, following #1644.

Resolves #1772

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced error handling for block size conditions to ensure more accurate logging and validation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 11, 2024 •
edited
Loading

Walkthrough

The change in state/executor.go modifies the condition for validating MaxBytes in state.ConsensusParams.Block from == 0 to <= 0. If this condition is met, an error log with an updated message is triggered. This adjustment aims to catch and log more cases where MaxBytes is non-positive.

Changes

File Change Summary
state/executor.go Updated condition check from == 0 to <= 0 for MaxBytes in state.ConsensusParams.Block, and modified the error log message.

Poem

In the code, a change we spun,
For MaxBytes now checks more than one.
If zero or less, we'll catch the plight,
Error logs will guide us right.
In bytes we trust, to scale and flow,
With this tweak, our systems grow. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RollkitBot RollkitBot requested review from a team, Manav-Aggarwal, tuxcanfly and tzdybal and removed request for a team July 11, 2024 20:22
coderabbitai[bot]
coderabbitai bot reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0b7c3ab and f90dc9a.

Files selected for processing (1)
  • state/executor.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • state/executor.go

tzdybal
tzdybal approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manav-Aggarwal Manav-Aggarwal enabled auto-merge July 15, 2024 17:12
@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Jul 15, 2024
@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.83%. Comparing base (c9d8467) to head (f90dc9a).
Report is 152 commits behind head on main.

Files Patch % Lines
state/executor.go 0.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (c9d8467) and HEAD (f90dc9a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c9d8467) HEAD (f90dc9a)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   50.23%   42.83%   -7.40%     
==========================================
  Files          52       75      +23     
  Lines        6762     9865    +3103     
==========================================
+ Hits         3397     4226     +829     
- Misses       3024     4930    +1906     
- Partials      341      709     +368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@tzdybal tzdybal added this pull request to the merge queue Jul 16, 2024
Merged via the queue into evstack:main with commit 8d7ba84 Jul 16, 2024
@Eoous Eoous deleted the verify_max_bytes branch April 17, 2025 16:39
@tac0turtle tac0turtle removed this from Evolve Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Manav-Aggarwal Manav-Aggarwal Manav-Aggarwal approved these changes

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

+1 more reviewer

@tzdybal tzdybal tzdybal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In ApplyBlock, verify if MaxBytes (int64) is less than 0

3 participants

@Eoous @tzdybal @Manav-Aggarwal