Conversation
liamsi
reviewed
Mar 23, 2021
p2p/utils_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func makeTestNetowork(t *testing.T, n int, conns map[int][]int, logger log.Logger) testNet { |
Contributor
There was a problem hiding this comment.
Yeah, this increases the readbility of the tests 👍🏼
Suggested change
| func makeTestNetowork(t *testing.T, n int, conns map[int][]int, logger log.Logger) testNet { | |
| func makeTestNetwork(t *testing.T, n int, conns map[int][]int, logger log.Logger) testNet { |
And the calling code as well.
Contributor
Author
There was a problem hiding this comment.
There should be 🤦 reaction :D
liamsi
reviewed
Mar 23, 2021
e97f4bf to
7777439
Compare
94e7acc to
5ba2324
Compare
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 72.07% 71.81% -0.26%
==========================================
Files 3 3
Lines 111 110 -1
==========================================
- Hits 80 79 -1
Misses 16 16
Partials 15 15
Continue to review full report at Codecov.
|
Merged
Wondertan
approved these changes
Mar 23, 2021
p2p/utils_test.go
Outdated
| t.Helper() | ||
| require := require.New(t) | ||
|
|
||
| mnet, err := mocknet.FullMeshLinked(context.Background(), n) |
Contributor
There was a problem hiding this comment.
Better create context at the beginning of the test and pass it here. That might be helpful in some tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of P2P layer tests.
Resolves #26, #27.