Summary of Changes

Hello @chatton, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new end-to-end test for the 'spamoor' transaction generation tool, ensuring its proper integration and functionality within the EVM ecosystem. To support this new test and provide more flexibility for future E2E scenarios, the common EVM test setup function has been enhanced to expose the underlying Reth full node instance. This change required minor adjustments across several existing test files to accommodate the updated function signature.

Highlights

• New E2E Test for Spamoor: A new end-to-end smoke test (TestSpamoorSmoke) has been added to validate the functionality of the 'spamoor' transaction spamming tool, integrating it with reth and sequencer nodes.
• Updated Common EVM Test Setup: The setupCommonEVMTest helper function now returns the reth.Node instance, allowing other tests to interact directly with the Reth full node. This required updates to all existing E2E tests that call this function.
• Dependency Updates: The go.mod file has been updated to include github.com/docker/go-connections and github.com/prometheus/client_model as direct dependencies, and a local replace directive for github.com/celestiaorg/tastora.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

Claude finished @chatton's task in 2m 9s —— View job

Code Review

• Gather context and read changed files
• Review new spamoor smoke test
• Review changes to common EVM test setup
• Review go.mod changes
• Review formatting changes in other test files
• Compile and post final review

Good addition overall — the test is well-structured, has meaningful assertions (addressing Gemini's TODO note), and uses proper cleanup via t.Cleanup. A few things worth addressing before merging:

test/e2e/evm_spamoor_smoke_test.go

1. context.Background() inconsistency (line 44)

ctx := t.Context() is defined at line 56, but context.Background() is used just above it on line 44. Move ctx := t.Context() to the top of the function body and reuse it everywhere:

// line 44 — should use ctx, not context.Background()
ni, err := rethNode.GetNetworkInfo(context.Background())

Fix this →

2. sumGauge is defined but never called (lines 166–177)

sumGauge is defined but has no callers anywhere in the test suite. Either use it or remove it to avoid dead code.

Fix this →

3. Bare time.Sleep not respecting context cancellation (lines 115, 123)

time.Sleep(60 * time.Second)  // line 115 — blocks regardless of test timeout
time.Sleep(2 * time.Second)   // line 123

If the test context is cancelled (timeout or signal), these sleeps will not be interrupted. Consider replacing with a context-aware sleep, e.g.:

select {
case <-time.After(60 * time.Second):
case <-ctx.Done():
    t.Fatal("context cancelled while waiting for spamoor activity")
}

4. requireHTTP doesn't accept context (line 132)

The helper uses a deadline loop but has no way to be cancelled by the test context. If the test times out mid-poll, it'll run to its own deadline before failing. Consider accepting a context.Context parameter.

test/e2e/evm_test_common.go

5. Stale doc comment on setupCommonEVMTest (line 515)

The comment says:

// Returns: jwtSecret, fullNodeJwtSecret (empty if needsFullNode=false), genesisHash

But the function now returns 5 values, with *reth.Node as the new last return. The comment should be updated to reflect this.

Fix this →

6. Function bloat acknowledged — follow-up ticket?

The PR author noted in a review comment that setupCommonEVMTest is "quite bloated." This function now returns 5 values. Worth tracking a follow-up issue to refactor it (e.g., return a struct), especially since further tests will likely need access to even more pieces of the setup.

test/e2e/go.mod

The Gemini review flagged a local replace directive for github.com/celestiaorg/tastora, but that isn't present in the current state of the file — it looks like it was already cleaned up. The existing replace directives for ev-node submodules are standard for this monorepo layout and are fine.

github.com/prometheus/client_model is correctly promoted to a direct dependency since it's explicitly imported in the new test file.

Summary

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.00%. Comparing base (a9c50d2) to head (a992fae).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3091      +/-   ##
==========================================
- Coverage   61.01%   61.00%   -0.02%     
==========================================
  Files         113      113              
  Lines       11544    11544              
==========================================
- Hits         7044     7042       -2     
- Misses       3701     3703       +2     
  Partials      799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.