chore: prep evm rc.5 by julienrbrt · Pull Request #3145 · evstack/ev-node

julienrbrt · 2026-03-09T15:47:31Z

Overview

Summary by CodeRabbit

Documentation
- Changelog has been updated with complete documentation for the v1.0.0 release, including detailed version consistency information.
Chores
- Internal package dependencies have been updated to the latest compatible versions to maintain system stability and cross-component compatibility.

coderabbitai · 2026-03-09T15:47:49Z

📝 Walkthrough

Walkthrough

This pull request updates release documentation and Go module dependencies. The CHANGELOG.md is modified to document v1.0.0 as stable and identical to v1.0.0-rc.5, while the EVM module's go.mod disables an active replace directive and updates a dependency version from rc.3 to rc.4.

Changes

Cohort / File(s)	Summary
Release Documentation `CHANGELOG.md`	Updated Unreleased section header to v1.0.0 and added clarification that it is identical to v1.0.0-rc.5.
Dependency Management `apps/evm/go.mod`	Disabled active replace directive for github.com/evstack/ev-node/execution/evm by converting to commented block; updated dependency version from v1.0.0-rc.3 to v1.0.0-rc.4.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

tac0turtle
alpe

Poem

🐰 A release hops into view so clean,
From rc.5 to v1.0, the stable scene,
Dependencies updated with gentle care,
Version bumps floating through the air,
The rabbit celebrates with a joyful bound! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description contains only the template placeholder with an empty Overview section and no actual implementation details or context about the changes.	Fill in the Overview section with a clear explanation of the RC.5 preparation changes, including why the dependency was updated and what the replace directive change accomplishes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: prep evm rc.5' directly relates to the main changes: updating the EVM module to RC.5 version and updating related dependencies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch julien/evm-rc5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

claude · 2026-03-09T15:50:44Z

Claude finished @julienrbrt's task in 1m 6s —— View job

Code Review

Read changed files
Review CHANGELOG.md changes
Review apps/evm/go.mod dependency updates
Provide final review summary

This is a clean, focused release prep PR. Here's the review:

CHANGELOG.md

The split of ## v1.0.0-rc.5 / v1.0.0 into two separate sections is a reasonable approach. Adding a v1.0.0 entry with a note stating it's identical to v1.0.0-rc.5 clearly documents the promotion from RC to stable.

Minor observation: The phrasing Identical to v1.0.0-rc.5. is slightly informal for a changelog. A more conventional entry might be:

## v1.0.0

Stable release. No code changes from v1.0.0-rc.5.

This is purely stylistic — not a blocker.

apps/evm/go.mod

Commenting out replace directives (CHANGELOG.md:5-8): Converting the active replace directive into a commented block is the right approach for a published release. The dev-time local replaces are preserved as comments for easy re-enabling during development, which is good practice.

Potential inconsistency (apps/evm/go.mod:12): The dependency on github.com/evstack/ev-node still pins v1.0.0-rc.5 rather than v1.0.0. If this PR is intended to ship v1.0.0, this should be updated once the v1.0.0 tag is published. If the intent is to prepare the changelog ahead of tagging and update go.mod separately after the tag is live, the current state is fine — but worth confirming.

Bump of execution/evm (apps/evm/go.mod:14): v1.0.0-rc.3 → v1.0.0-rc.4 is a straightforward patch bump. The corresponding go.sum entries look correct.

Summary

The changes are minimal and well-scoped. The one item worth verifying before merging: should github.com/evstack/ev-node in go.mod be updated to v1.0.0 once that tag is cut? If yes, consider adding a follow-up task or doing it as part of post-tagging automation. Otherwise, LGTM.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/evm/go.mod`:
- Around line 5-14: The go.mod currently requires github.com/evstack/ev-node
v1.0.0-rc.5 but pins github.com/evstack/ev-node/execution/evm at v1.0.0-rc.4;
re-align them by either updating the execution/evm require to v1.0.0-rc.5 or, if
v1.0.0-rc.5 isn’t published yet, re-enable the local replace block that points
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to the
sibling workspace so the module builds against the in-repo rc.5 execution code.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cf59bd2-d62a-4203-9589-f2644523edcb

📥 Commits

Reviewing files that changed from the base of the PR and between e599cae and d50b9c5.

⛔ Files ignored due to path filters (1)

apps/evm/go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

CHANGELOG.md
apps/evm/go.mod

coderabbitai · 2026-03-09T15:51:46Z

apps/evm/go.mod

+//replace (
+//	github.com/evstack/ev-node => ../../
+//	github.com/evstack/ev-node/execution/evm => ../../execution/evm
+//)

 require (
 	github.com/ethereum/go-ethereum v1.17.0
 	github.com/evstack/ev-node v1.0.0-rc.5
 	github.com/evstack/ev-node/core v1.0.0
-	github.com/evstack/ev-node/execution/evm v1.0.0-rc.3
+	github.com/evstack/ev-node/execution/evm v1.0.0-rc.4


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash set -euo pipefail echo "== apps/evm/go.mod ==" sed -n '1,25p' apps/evm/go.mod echo echo "== execution/evm/go.mod ==" sed -n '1,20p' execution/evm/go.mod echo echo "== workspace files ==" fd '^go\.work(\.example)?$' -a echo echo "== version pins for ev-node/execution/evm across go.mod files ==" rg -n --glob 'go.mod' 'github\.com/evstack/ev-node/execution/evm v'

Repository: evstack/ev-node

Length of output: 1873

Align apps/evm with the rc.5 execution module before cutting this release.

Line 14 pins github.com/evstack/ev-node/execution/evm to v1.0.0-rc.4 while this module already depends on github.com/evstack/ev-node v1.0.0-rc.5. With the local replace block disabled (lines 5-8), apps/evm will resolve the published rc.4 execution module instead of the in-repo sibling, causing this PR to be built and validated against older execution code than the release describes.

Suggested fix

-//replace ( -// github.com/evstack/ev-node => ../../ -// github.com/evstack/ev-node/execution/evm => ../../execution/evm -//) +replace ( + github.com/evstack/ev-node => ../../ + github.com/evstack/ev-node/execution/evm => ../../execution/evm +) @@ - github.com/evstack/ev-node/execution/evm v1.0.0-rc.4 + github.com/evstack/ev-node/execution/evm v1.0.0-rc.5

If v1.0.0-rc.5 is not published yet, keep the local replace active until it is.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@apps/evm/go.mod` around lines 5 - 14, The go.mod currently requires github.com/evstack/ev-node v1.0.0-rc.5 but pins github.com/evstack/ev-node/execution/evm at v1.0.0-rc.4; re-align them by either updating the execution/evm require to v1.0.0-rc.5 or, if v1.0.0-rc.5 isn’t published yet, re-enable the local replace block that points github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm to the sibling workspace so the module builds against the in-repo rc.5 execution code.

github-actions · 2026-03-09T15:52:26Z

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`⏩ skipped`	`✅ passed`	`✅ passed`	Mar 9, 2026, 3:52 PM

chore: prep evm rc.5

d50b9c5

github-actions bot assigned julienrbrt Mar 9, 2026

coderabbitai bot reviewed Mar 9, 2026

View reviewed changes

tac0turtle approved these changes Mar 9, 2026

View reviewed changes

julienrbrt merged commit 87d8ba9 into main Mar 9, 2026
28 of 30 checks passed

julienrbrt deleted the julien/evm-rc5 branch March 9, 2026 15:56

alpe mentioned this pull request Mar 9, 2026

feat: Subscribe to forced inclusion ns events #3146

Open

coderabbitai bot mentioned this pull request Mar 12, 2026

build(deps): bump ev-node #3159

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: prep evm rc.5#3145

chore: prep evm rc.5#3145
julienrbrt merged 1 commit intomainfrom
julien/evm-rc5

julienrbrt commented Mar 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

claude bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

julienrbrt commented Mar 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

claude bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

CHANGELOG.md

apps/evm/go.mod

Summary

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

julienrbrt commented Mar 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 9, 2026 •

edited

Loading

claude bot commented Mar 9, 2026 •

edited

Loading