Skip to content

chore: re-add replaces for development#3161

Merged
julienrbrt merged 2 commits intomainfrom
julien/chore
Mar 13, 2026
Merged

chore: re-add replaces for development#3161
julienrbrt merged 2 commits intomainfrom
julien/chore

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 12, 2026 •
edited
Loading

Overview

Re-add the apps replaces for development, now that v1.0.0 is tagged.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Warning

Rate limit exceeded

@julienrbrt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a9516e4-2788-4b6a-9043-55f6fefc9046

📥 Commits

Reviewing files that changed from the base of the PR and between d6bbca6 and 44e4efc.

📒 Files selected for processing (2)
  • apps/evm/go.mod
  • apps/testapp/go.mod
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch julien/chore
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Contributor

claude bot commented Mar 12, 2026 •
edited
Loading

Claude finished @julienrbrt's task in 1m 25s —— View job

Code Review

  • Gather context and analyze PR changes
  • Review go.mod changes
  • Provide final assessment

Summary

This PR re-adds local replace directives to apps/evm/go.mod and apps/testapp/go.mod for development, following the pattern already present in apps/grpc/go.mod. The previous bump commit (#3160) had commented them out; this restores them as active replace blocks.

Changes Reviewed

apps/evm/go.mod — Adds:

replace (
    github.com/evstack/ev-node => ../../
    github.com/evstack/ev-node/execution/evm => ../../execution/evm
)

apps/testapp/go.mod — Adds:

replace github.com/evstack/ev-node => ../../.

Observations

Correctness: The replace directives are valid relative paths within this monorepo and are consistent with the existing pattern in apps/grpc/go.mod. Nothing suspicious here.

Minor inconsistency (non-blocking): apps/testapp/go.mod uses ../../. while apps/evm/go.mod uses ../../. These are functionally equivalent, but normalizing to ../../ (without the trailing dot) would be slightly cleaner for consistency.

Missing core replace: Neither apps/evm nor apps/testapp adds a replace for github.com/evstack/ev-node/core, even though it's a direct dependency in both. However, this matches the pattern in apps/grpc/go.mod, so it appears intentional — core likely doesn't need local replacement in the current dev workflow.

go.sum cleanup: The corresponding entries were removed from go.sum files as expected when switching from resolved versions to local paths.

Verdict

The changes are straightforward and correct. This follows the established monorepo development pattern. LGTM.

@julienrbrt julienrbrt enabled auto-merge March 12, 2026 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 12, 2026, 4:48 PM

@codecov
Copy link

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.20%. Comparing base (d6bbca6) to head (3efc8c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3161   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         115      115           
  Lines       11896    11896           
=======================================
  Hits         7162     7162           
  Misses       3923     3923           
  Partials      811      811
Flag Coverage Δ
combined 60.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alpe
alpe approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julienrbrt julienrbrt added this pull request to the merge queue Mar 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2026
@julienrbrt julienrbrt merged commit 03fef96 into main Mar 13, 2026
32 checks passed
@julienrbrt julienrbrt deleted the julien/chore branch March 13, 2026 12:57
alpe added a commit that referenced this pull request Mar 13, 2026
@alpe
Merge branch 'main' into fix/catchup-startup-race-main
478bc84 
* main:
  chore: re-add replaces for development (#3161)
alpe added a commit that referenced this pull request Mar 13, 2026
@alpe
Merge branch 'main' into alex/2803_best_2worlds_fi_rebased2
c31af08 
* main:
  fix(syncer): include in-flight and pending-cache work in PendingCount (#3162)
  chore: re-add replaces for development (#3161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alpe alpe alpe approved these changes

Assignees

@julienrbrt julienrbrt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julienrbrt @alpe