support astro 6.0 #415
support astro 6.0 #415
Conversation
✅ Deploy Preview for expressive-code ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I noticed that Astro v6 requires a minimum Node.js version of v22. It seems the current CI environment is running on Node v18, which is causing the build to fail. I'm having a bit of trouble locating the specific workflow configuration to update the Node.js version. Could you point me to the right file to modify, or assist with updating the CI environment? Thanks! |
I think that’s only the Netlify site build you’re seeing failing, which needs setting in the dashboard (I don’t have access personally). But I think we need to keep the docs site running on Astro 5 for now, so no need to update that CI environment. In the actual CI test workflow it’s erroring because the |
| }, | ||
| "peerDependencies": { | ||
| "astro": "^4.0.0-beta || ^5.0.0-beta || ^3.3.0" | ||
| "astro": "^3.3.0 || ^4.0.0-beta || ^5.0.0-beta || ^6.0.0-beta" |
There was a problem hiding this comment.
As far as I remember, the order of versions in the peerDependencies -> astro field is important as it influences which Astro types the project is built with.
In an earlier PR, I had to make a commit to switch the order of packages around to ensure that the proper Astro version's TypeScript types are being used.
Your change here would cause the build process to use outdated Astro 3 types. I'd recommend keeping this in the previous order and just adding || ^6.0.0-beta to the end to keep potential side effects of your changes minimal.
There was a problem hiding this comment.
Thanks for the explanation! I wasn't aware that the order in peerDependencies would influence the resolved version for the build types.
I've reverted the order to the original state and appended || ^6.0.0-beta at the very end to minimize side effects.
Supports the upcoming astro 6.0 version.