chore: Update integration testing documentation by kevjumba · Pull Request #2983 · feast-dev/feast

kevjumba · 2022-07-28T23:13:09Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

codecov-commenter · 2022-07-28T23:22:09Z

Codecov Report

Merging #2983 (240a3c9) into master (2680f7b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2983      +/-   ##
==========================================
+ Coverage   77.82%   77.84%   +0.02%     
==========================================
  Files         192      194       +2     
  Lines       16427    16560     +133     
==========================================
+ Hits        12784    12891     +107     
- Misses       3643     3669      +26

Flag	Coverage Δ
integrationtests	`67.37% <ø> (-0.64%)`	⬇️
unittests	`59.85% <ø> (+0.78%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/utils/snowflake_utils.py	`77.77% <0.00%> (-7.05%)`	⬇️
sdk/python/feast/infra/online_stores/datastore.py	`87.96% <0.00%> (-1.39%)`	⬇️
...ocal_feast_tests/test_stream_feature_view_apply.py	`97.95% <0.00%> (-0.66%)`	⬇️
sdk/python/tests/utils/basic_read_write_test.py	`100.00% <0.00%> (ø)`
...python/tests/integration/e2e/test_universal_e2e.py	`100.00% <0.00%> (ø)`
...python/tests/unit/cli/test_cli_apply_duplicates.py	`100.00% <0.00%> (ø)`
...hon/tests/unit/local_feast_tests/test_e2e_local.py	`100.00% <0.00%> (ø)`
...nit/local_feast_tests/test_feature_service_read.py	`100.00% <0.00%> (ø)`
.../integration/online_store/test_online_retrieval.py
sdk/python/feast/infra/online_stores/snowflake.py	`98.13% <0.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2680f7b...240a3c9. Read the comment docs.

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

sdk/python/tests/README.md

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

docs/how-to-guides/adding-or-reusing-tests.md

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817

/lgtm

feast-ci-bot · 2022-08-02T20:29:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Refactor go feature server Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix e2e tests Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Verify tests Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Address review Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Address review Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * address review Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Refactor Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fx lit Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Revert Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Add more docs Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Swap Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * More thingies Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix rebase Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix rebase Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * address review Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix release Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

feast-ci-bot added approved size/XXL labels Jul 28, 2022

kevjumba added the do-not-merge/work-in-progress label Jul 29, 2022

kevjumba changed the title ~~chore: Integration test docs~~ chore: Integration test docs{WIP} Jul 29, 2022

feast-ci-bot removed the do-not-merge/work-in-progress label Jul 29, 2022

kevjumba added 24 commits July 29, 2022 13:35

Refactor go feature server

8fd1a21

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix lint

c5409fa

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix e2e tests

e1af436

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

a0a10c7

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Verify tests

5832e59

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix lint

6e589a8

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Address review

f453bf7

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

6d08838

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Address review

8fe04e5

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

cccd0f1

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix lint

b203354

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

address review

737c86a

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

6c01445

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

bdd6960

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix lint

b384b6d

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

d4dbd7f

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Refactor

bce4853

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

7ca6d81

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fx lit

1fc254b

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix lint

3af8016

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

938b6a2

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Revert

ba76096

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

fix

458d22b

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

43cb8b5

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba added 5 commits July 29, 2022 13:45

More thingies

7fade92

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

450455c

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

ed0018e

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

e2a015a

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix rebase

f8f733f

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba force-pushed the integration_test_docs branch from 9d4d920 to f8f733f Compare July 29, 2022 20:50

feast-ci-bot added size/L and removed size/XXL labels Jul 29, 2022

kevjumba added 2 commits July 29, 2022 13:51

Fix rebase

ca2861d

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

fix lint

ad3c2c2

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba changed the title ~~chore: Integration test docs{WIP}~~ chore: Integration test docs Aug 2, 2022

Fix

0d7bea2

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

feast-ci-bot added size/XL and removed size/L labels Aug 2, 2022

kevjumba changed the title ~~chore: Integration test docs~~ chore: Update integration testing documentation Aug 2, 2022

felixwang9817 reviewed Aug 2, 2022

View reviewed changes

address review

806132c

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817 reviewed Aug 2, 2022

View reviewed changes

docs/how-to-guides/adding-or-reusing-tests.md Outdated Show resolved Hide resolved

felixwang9817 reviewed Aug 2, 2022

View reviewed changes

kevjumba added 2 commits August 2, 2022 13:11

Fix

795db03

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix release

240a3c9

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817 approved these changes Aug 2, 2022

View reviewed changes

feast-ci-bot assigned felixwang9817 Aug 2, 2022

feast-ci-bot added the lgtm label Aug 2, 2022

feast-ci-bot merged commit bcecbe7 into feast-dev:master Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update integration testing documentation#2983

chore: Update integration testing documentation#2983
feast-ci-bot merged 39 commits intofeast-dev:masterfrom
kevjumba:integration_test_docs

kevjumba commented Jul 28, 2022

Uh oh!

codecov-commenter commented Jul 28, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixwang9817 left a comment

Uh oh!

feast-ci-bot commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kevjumba commented Jul 28, 2022

Uh oh!

codecov-commenter commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixwang9817 left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 28, 2022 •

edited

Loading